feat(image): [android] adding force-cache cache control option
#47426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mateoguzmana
commented
Nov 5, 2024
...ve/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/ReactOkHttpNetworkFetcher.kt
Show resolved
Hide resolved
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Abbondanzo
requested changes
Nov 7, 2024
Contributor
Abbondanzo
left a comment
Abbondanzo
left a comment
There was a problem hiding this comment.
The cacheControlBuilder has noStore set, so none of the responses are getting cached.
- Could you modify the builder to set
noStoreon the default andreloadbranches? - Could you update the
only-if-cachedbranch to use the same max-age logic?
…or only-if-cached
Collaborator
Author
|
@Abbondanzo thanks a lot again for taking the time to check these PRs! I've addressed all the feedback in dca3d3a |
Contributor
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@Abbondanzo merged this pull request in a0be88f. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in a0be88f When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…ts (#47953) Summary: This is a follow up for the new cache control options for the Android Image component introduced in #47182, #47348 & #47426. And to make sure the cache control header works as expected and avoid missing the issue fixed in #47922, this PR introduces test cases to make sure this is getting applied as expected in the `ReactOkHttpNetworkFetcher`. ## Changelog: [INTERNAL] [ADDED] - `ReactOkHttpNetworkFetcher` cache control tests Pull Request resolved: #47953 Test Plan: ```bash yarn test-android ``` Reviewed By: rshest Differential Revision: D66498305 Pulled By: javache fbshipit-source-id: 7a9a0cc596e49964943e59189614743ca8a472a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR follows up on #47182 and #47348 by adding
force-cache, the final missing option to align caching controls with the existing behavior on iOS.Local caching behavior remains unchanged: if a cached image is available locally, it will be returned; otherwise, a network request will be made.
When an image request is sent over the network, the
force-cacheoption sent from the sent fJS side will now use theokhttp3.CacheControl.FORCE_CACHEdirective.Changelog:
[ANDROID] [ADDED] - Image
force-cachecaching control optionTest Plan:
New example added to the RNTester under the cache policy examples. Then inspecting that the cache control is set correctly before sending it in the
okhttp3.Requestbuilder.This case was a bit more tricky to test in terms of e2e as it would involve some caching in the server as well, I'm open to suggestions to make this more complete.