Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Replace UnimplementedView with UnimplementedNativeView #46297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[iOS] Replace UnimplementedView with UnimplementedNativeView #46297

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Seems we already have the fallback descriptor mechanism, we can use UnimplementedNativeView to show un-support components and not need UnimplementedView anymore.

Changelog:

[IOS] [CHANGED] - Replace UnimplementedView with UnimplementedNativeView

Test Plan:

Show UnimplementedNativeView for un-supported components.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 2, 2024
cipolleschi
cipolleschi approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.
I don't fully grasp everything that happened in that layer, but I'll show this around internally to get more eyes on this.

Sorry if it took some time to get to this PR, I missed it.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

Just to set expectation, this will take a bit of time to land as several internal apps were using the component that got removed, so I have to spend some time to refactor them as well, before landing the diff.

@zhongwuzw
Copy link
Contributor Author

@cipolleschi Thanks for the work. Are they only use component class directly? whether we can rename the new component class name to the removed component name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongwuzw @facebook-github-bot @cipolleschi