Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixes js bundle failed #45155

Closed

Conversation

zhongwuzw
Copy link
Contributor

Summary:

When I enabled FORCE_BUNDLING, it build errors like below. cc @blakef
image

Changelog:

[INTERNAL] [FIXED] - Fixes js bundle failed

Test Plan:

Enable FORCE_BUNDLING and build success.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 25, 2024
@analysis-bot
Copy link

analysis-bot commented Jun 25, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,496,113 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,693,471 -10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4a8f0ee
Branch: main

@blakef
Copy link
Contributor

blakef commented Jun 25, 2024

Thanks for the PR, can you give the output of npx @react-native-community/cli@latest info from your project please?

@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@blakef
Copy link
Contributor

blakef commented Jun 25, 2024

@zhongwuzw while working on the 0.75.0 RC1 we hit this issue. Thank you for the fix!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 25, 2024
@facebook-github-bot
Copy link
Contributor

@blakef merged this pull request in 70b43bb.

Copy link

This pull request was successfully merged by @zhongwuzw in 70b43bb.

When will my fix make it into a release? | How to file a pick request?

cortinico pushed a commit that referenced this pull request Jun 26, 2024
Summary:
When I enabled `FORCE_BUNDLING`, it build errors like below. cc blakef
![image](https://github.com/facebook/react-native/assets/5061845/d23f6bad-ed60-4f1f-8111-2361c93e93a4)

## Changelog:

[INTERNAL] [FIXED] - Fixes js bundle failed

Pull Request resolved: #45155

Test Plan: Enable FORCE_BUNDLING and build success.

Reviewed By: cipolleschi

Differential Revision: D59006962

Pulled By: blakef

fbshipit-source-id: 1142d1ddbae7346b67712fac0237950847211992
Copy link

This pull request was successfully merged by @zhongwuzw in 4783de7.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants