Implemented font-variation-settings for iOS#44685
Implemented font-variation-settings for iOS#44685davebcn87 wants to merge 1 commit intofacebook:mainfrom
font-variation-settings for iOS#44685Conversation
|
Hi @davebcn87! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
b491a59 to
7d9c27e
Compare
7d9c27e to
2f062e0
Compare
Base commit: a908387 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
|
Please reopen the PR. |
|
has this been abandoned ? |
|
@ovy9086 I didn’t get a chance to continue working on it after I left DD 😆 I also collaborated with @davebcn87 on it for a while. Android PR: #36371 We eventually paused work on it because the main branch was changing rapidly with the new architecture updates, which led to a lot of conflicts. |
Summary:
This PR extends the support on React Native for variable fonts. This allow to customize any font setting:
wght,slnt,wdthare common examples. A font designer can use any custom attribute, this is what we made this feature compatible with any property.It follows the css standard
font-variation-settings. This attribute is a string, formatted as a key value pairs separated by commas:Screenshots
The Android implementation of this feature is being implemented by another PR from @matinzd. We've been pairing on this solution to follow a similar implementation for both platforms.
Changelog:
[iOS] [ADDED] - Add fontVariationSettings support for variable fonts in iOS
Test Plan:
I've added examples in the
rn-testerapp using variable fonts. I've tested the following scenarios:wght,wdth,slnt.FILLfont-variation-settingswith other styles that affect font descriptors, likefont-variant. Seetabular-numsexample.This is an example of the final implementation usage code: