Implemented font-variation-settings
for iOS
#44685
Open
+273
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extends the support on React Native for variable fonts. This allow to customize any font setting:
wght
,slnt
,wdth
are common examples. A font designer can use any custom attribute, this is what we made this feature compatible with any property.It follows the css standard
font-variation-settings
. This attribute is a string, formatted as a key value pairs separated by commas:Screenshots
The Android implementation of this feature is being implemented by another PR from @matinzd. We've been pairing on this solution to follow a similar implementation for both platforms.
Changelog:
[iOS] [ADDED] - Add fontVariationSettings support for variable fonts in iOS
Test Plan:
I've added examples in the
rn-tester
app using variable fonts. I've tested the following scenarios:wght
,wdth
,slnt
.FILL
font-variation-settings
with other styles that affect font descriptors, likefont-variant
. Seetabular-nums
example.This is an example of the final implementation usage code: