Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing exposing ReactDelegate through ReactActivity for reload() #44227

Closed

Conversation

arushikesarwani94
Copy link
Contributor

@arushikesarwani94 arushikesarwani94 commented Apr 23, 2024

Summary: In #44223 @Kudo identified the incorrect return type.

Differential Revision: D56497700

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56497700

…ebook#44227)

Summary:

In facebook#44223 kudo identified the incorrect return type.

Differential Revision: D56497700
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56497700

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,410,908 +7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,784,326 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 995d5b8
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e25860f.

Copy link

This pull request was successfully merged by @arushikesarwani94 in e25860f.

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request May 1, 2024
)

Summary:
Pull Request resolved: #44227

In #44223 kudo identified the incorrect return type.

Reviewed By: christophpurrer, philIip

Differential Revision: D56497700

fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request May 6, 2024
…ebook#44227)

Summary:
Pull Request resolved: facebook#44227

In facebook#44223 kudo identified the incorrect return type.

Reviewed By: christophpurrer, philIip

Differential Revision: D56497700

fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…ebook#44227)

Summary:
Pull Request resolved: facebook#44227

In facebook#44223 kudo identified the incorrect return type.

Reviewed By: christophpurrer, philIip

Differential Revision: D56497700

fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants