Fix InteropUIBlockListener to support react-native-view-shot on Bridgeless #43594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55187939 |
Base commit: c574ca5 |
|
This pull request was exported from Phabricator. Differential Revision: D55187939 |
…eless (facebook#43594) Summary: I've been migrating `react-native-view-shot` to Fabric by using the `InteropUiBlockListener` and I've realized that the interop layer doesn't work well. 1. FabricUIManager needs to implement `UIBlockViewResolver` in order for the interop layer to work correctly. 2. We need to hook `addUIBlock` to the `didDispatchMountItems` callback otherwise the UIBlocks won't be executed at all. Changelog: [Android] [Fixed] - Fix InteropUIBlockListener to support react-native-view-shot on Bridgeless Differential Revision: D55187939
cortinico
force-pushed
the
export-D55187939
branch
from
7103225
to
eab00cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55187939 |
|
This pull request has been merged in 24a3dad. |
huntie
pushed a commit
that referenced
this pull request
Mar 25, 2024
…eless (#43594) Summary: Pull Request resolved: #43594 I've been migrating `react-native-view-shot` to Fabric by using the `InteropUiBlockListener` and I've realized that the interop layer doesn't work well. 1. FabricUIManager needs to implement `UIBlockViewResolver` in order for the interop layer to work correctly. 2. We need to hook `addUIBlock` to the `didDispatchMountItems` callback otherwise the UIBlocks won't be executed at all. Changelog: [Android] [Fixed] - Fix InteropUIBlockListener to support react-native-view-shot on Bridgeless Reviewed By: javache Differential Revision: D55187939 fbshipit-source-id: d048b4b5eed77fa856fdfac17c0df5f23fd44844
This was referenced Apr 5, 2024
This was referenced Apr 12, 2024
Closed
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've been migrating
react-native-view-shotto Fabric by using theInteropUiBlockListenerand I've realized that the interop layer doesn't work well.
UIBlockViewResolverin order for the interop layer to work correctly.addUIBlockto thedidDispatchMountItemscallback otherwise the UIBlocks won't be executed at all.Changelog:
[Android] [Fixed] - Fix InteropUIBlockListener to support react-native-view-shot on Bridgeless
Differential Revision: D55187939