-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support onKeyDown in Bridgeless #43466
Closed
arushikesarwani94
wants to merge
2
commits into
facebook:main
from
arushikesarwani94:export-D54870966
Closed
Support onKeyDown in Bridgeless #43466
arushikesarwani94
wants to merge
2
commits into
facebook:main
from
arushikesarwani94:export-D54870966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 13, 2024
This pull request was exported from Phabricator. Differential Revision: D54870966 |
Summary: Adding the ReactHost null check in the APIs added for ReactDelegate lately. Changelog: [Internal] internal Differential Revision: D54864907
Summary: Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl Changelog: [Android][Breaking] Implement `onKeyDown` in Bridgeless Differential Revision: D54870966
arushikesarwani94
force-pushed
the
export-D54870966
branch
from
March 13, 2024 22:21
33f33bc
to
95447be
Compare
This pull request was exported from Phabricator. Differential Revision: D54870966 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 14, 2024
Summary: Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl Changelog: [Android][Breaking] Implement `onKeyDown` in Bridgeless Differential Revision: D54870966
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 14, 2024
Summary: Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl Changelog: [Android][Breaking] Implement `onKeyDown` in Bridgeless Differential Revision: D54870966
This pull request has been merged in b14f7d5. |
cortinico
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: #43466 Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl Changelog: [Android][Breaking] Implement `onKeyDown` in Bridgeless Reviewed By: cortinico Differential Revision: D54870966 fbshipit-source-id: 0f8e48b29679f1bca92f6ac7b6ebf1592cdc5dac
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement
onKeyDown
in Bridgeless by adding it to ReactHostImplChangelog:
[Android][Breaking] Implement
onKeyDown
in BridgelessDifferential Revision: D54870966