Fix bug where absolute nodes were not insetted correctly in certain cases #43417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54703955 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Mar 11, 2024
…ases Summary: X-link: facebook/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Mar 11, 2024
…ases (facebook#43417) Summary: There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilches
force-pushed
the
export-D54703955
branch
from
04e0e4c
to
32d1f60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54703955 |
…ases (facebook#43417) Summary: X-link: facebook/yoga#1593 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Mar 12, 2024
…ases (facebook#1593) Summary: X-link: facebook/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilches
force-pushed
the
export-D54703955
branch
from
32d1f60
to
4b2f7c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54703955 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Mar 12, 2024
…ases Summary: X-link: facebook/yoga#1593 X-link: facebook/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Mar 12, 2024
…ases (#1593) Summary: Pull Request resolved: #1593 X-link: facebook/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
|
This pull request has been merged in 3341ab7. |
NickGerleman
pushed a commit
to facebook/yoga
that referenced
this pull request
Mar 13, 2024
…ases (#1593) Summary: Pull Request resolved: #1593 X-link: facebook/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
…ases (#43417) Summary: X-link: facebook/yoga#1593 Pull Request resolved: #43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening
Reviewed By: NickGerleman
Differential Revision: D54703955