-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getJSCallInvokerHolder for BridgelessCatalystInstance #43400
Closed
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D54650305
Closed
Implement getJSCallInvokerHolder for BridgelessCatalystInstance #43400
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D54650305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Implement `getJSCallInvokerHolder()` for BridgelessCatalystInstance Changelog: [Android][Breaking] Implement `getJSCallInvokerHolder()` for Bridgeless Catalyst Instance Reviewed By: cortinico Differential Revision: D54650305
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 9, 2024
This pull request was exported from Phabricator. Differential Revision: D54650305 |
This pull request has been merged in c6076bc. |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 11, 2024
Summary: facebook#43400 caused a `getCatalystInstanceTest` to fail in OSS due to `bridgelessReactContext` not being a Mock object. Differential Revision: D54781539
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 11, 2024
Summary: facebook#43400 caused a `getCatalystInstanceTest` to fail in OSS due to `bridgelessReactContext` not being a Mock object. Differential Revision: D54781539
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 12, 2024
Summary: facebook#43400 caused a `getCatalystInstanceTest` to fail in OSS due to `bridgelessReactContext` not being a Mock object. Reviewed By: fkgozali Differential Revision: D54781539
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 12, 2024
Summary: facebook#43400 caused a `getCatalystInstanceTest` to fail in OSS due to `bridgelessReactContext` not being a Mock object. Reviewed By: fkgozali Differential Revision: D54781539
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #43400 Implement `getJSCallInvokerHolder()` for BridgelessCatalystInstance Changelog: [Android][Breaking] Implement `getJSCallInvokerHolder()` for Bridgeless Catalyst Instance Reviewed By: cortinico Differential Revision: D54650305 fbshipit-source-id: effac3daaad5173c2fd78ab11bbe3f3156a9c07b
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement
getJSCallInvokerHolder()
for BridgelessCatalystInstanceChangelog:
[Android][Breaking] Implement
getJSCallInvokerHolder()
for Bridgeless Catalyst InstanceReviewed By: cortinico
Differential Revision: D54650305