fix(dev-middleware): fix react-native config failing in pnpm setups
#42907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
```
% node --print 'require("react-native/react-native.config.js")'
node:internal/modules/cjs/loader:1137
throw err;
^
Error: Cannot find module 'ws'
```
tido64
force-pushed
the
tido/missing-ws
branch
from
537083e
to
2aac1a6
Compare
facebook-github-bot
added
the
Shared with Meta
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 8da1da2 |
lunaleaps
pushed a commit
that referenced
this pull request
Feb 19, 2024
…#42907) Summary: In a pnpm setup, `react-native config` fails to read `react-native/react-native.config.js` because `ws` was not installed: ``` % node --print 'require("react-native/react-native.config.js")' node:internal/modules/cjs/loader:1137 throw err; ^ Error: Cannot find module 'ws' ``` ## Changelog: [GENERAL] [FIXED] - fix `react-native config` failing in pnpm setups Pull Request resolved: #42907 Test Plan: n/a Reviewed By: cipolleschi Differential Revision: D53516703 Pulled By: robhogan fbshipit-source-id: 3aded393187df4ca9a7abb64a2c8e0f2c9a5fcd9
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In a pnpm setup,
react-native configfails to readreact-native/react-native.config.jsbecausewswas not installed:Changelog:
[GENERAL] [FIXED] - fix
react-native configfailing in pnpm setupsTest Plan:
n/a