refactor[ReadOnlyNode]: lazy import ReactFabric #42285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52784886 |
hoxyq
force-pushed
the
export-D52784886
branch
from
172f314 to
837931d
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Reviewed By: rubennorte Differential Revision: D52784886
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…2285) Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Reviewed By: rubennorte Differential Revision: D52784886
|
This pull request was exported from Phabricator. Differential Revision: D52784886 |
Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Reviewed By: rubennorte Differential Revision: D52784886
hoxyq
force-pushed
the
export-D52784886
branch
from
837931d to
25bffc5
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…2285) Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Reviewed By: rubennorte Differential Revision: D52784886
|
This pull request was exported from Phabricator. Differential Revision: D52784886 |
|
This pull request has been merged in 0d10216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Having a static import of
ReactFabricblocks from usingReactNativeElementclass for Paper-only applications.Although DOM Node APIs are Fabric-only, the ability to use
instanceof ReactNativeElementis a nice tool for gating purposes, which currently can't be used because of the static import.Differential Revision: D52784886