Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch #42094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
NickGerleman
force-pushed
the
export-D52451602
branch
from
4e6a8d9 to
f608fcc
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Dec 29, 2023
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Differential Revision: D52451602
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
mmmoussa
reviewed
Dec 29, 2023
Contributor
mmmoussa
left a comment
mmmoussa
left a comment
There was a problem hiding this comment.
Tested this in my project and confirmed that it fixes the issue
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
NickGerleman
force-pushed
the
export-D52451602
branch
from
f608fcc to
f8cde4b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 3, 2024
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
NickGerleman
force-pushed
the
export-D52451602
branch
from
f8cde4b to
34033ab
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 3, 2024
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
NickGerleman
force-pushed
the
export-D52451602
branch
from
34033ab to
53f0e11
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52451602 |
Contributor
|
This pull request has been merged in e809e0a. |
huntie
pushed a commit
that referenced
this pull request
Jan 3, 2024
…#42094) Summary: Pull Request resolved: #42094 Fabric fixed this a while back with 9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. #38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602 fbshipit-source-id: f41d8248c7f6ab23965800b09ca1082fd1a15151
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…facebook#42094) Summary: Pull Request resolved: facebook#42094 Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602 fbshipit-source-id: f41d8248c7f6ab23965800b09ca1082fd1a15151
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fabric fixed this a while back with 9ca460f
Looks like this is still broken on Paper, and now VirtualizedList relies on it. #38737 (comment)
Changelog:
[ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch
Differential Revision: D52451602