-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][CI] Install bundler versions depending on Ruby version #41962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Dec 16, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: b221265 |
@cipolleschi merged this pull request in 479b4bb. |
fortmarek
pushed a commit
that referenced
this pull request
Dec 19, 2023
Summary: Since yesterday evening (why it is always friday evening???) CircleCI or Gem decided to update the default bundler version that is installed with `gem bundle install`. Therefore, CI for iOS stopped working. This change installs bundler's versions so that they are compatible with the Ruby version. [Internal] - Fix CI for iOS installing versions of bundler that are compatible with Ruby Pull Request resolved: #41962 Test Plan: CircleCI is green Reviewed By: GijsWeterings Differential Revision: D52230544 Pulled By: cipolleschi fbshipit-source-id: 2f96e16ecb94159953056e8de757ea4d249f80f0
lunaleaps
pushed a commit
that referenced
this pull request
Dec 22, 2023
Summary: Since yesterday evening (why it is always friday evening???) CircleCI or Gem decided to update the default bundler version that is installed with `gem bundle install`. Therefore, CI for iOS stopped working. This change installs bundler's versions so that they are compatible with the Ruby version. ## Changelog: [Internal] - Fix CI for iOS installing versions of bundler that are compatible with Ruby Pull Request resolved: #41962 Test Plan: CircleCI is green Reviewed By: GijsWeterings Differential Revision: D52230544 Pulled By: cipolleschi fbshipit-source-id: 2f96e16ecb94159953056e8de757ea4d249f80f0
This was referenced Dec 27, 2023
This was referenced Jan 4, 2024
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Since yesterday evening (why it is always friday evening???) CircleCI or Gem decided to update the default bundler version that is installed with `gem bundle install`. Therefore, CI for iOS stopped working. This change installs bundler's versions so that they are compatible with the Ruby version. ## Changelog: [Internal] - Fix CI for iOS installing versions of bundler that are compatible with Ruby Pull Request resolved: facebook#41962 Test Plan: CircleCI is green Reviewed By: GijsWeterings Differential Revision: D52230544 Pulled By: cipolleschi fbshipit-source-id: 2f96e16ecb94159953056e8de757ea4d249f80f0
This was referenced Jan 10, 2024
This was referenced Feb 28, 2024
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since yesterday evening (why it is always friday evening???) CircleCI or Gem decided to update the default bundler version that is installed with
gem bundle install
.Therefore, CI for iOS stopped working.
This change installs bundler's versions so that they are compatible with the Ruby version.
Changelog:
[Internal] - Fix CI for iOS installing versions of bundler that are compatible with Ruby
Test Plan:
CircleCI is green