Fix AndroidTextInputProps Detection of Padding #41643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51566900 |
Base commit: c464b21 |
Summary: Code in `AndroidTextInputComponentDescriptor` will rewrite Yoga props for padding based on Android theme, if a value isn't supplied. It determines this by adding props in `AndroidTextInputProps` which reads Yoga RawProps to tell if they were set. RawProps are keyed using separate prefix/name/suffix, instead of the combined string name of the prop. This means that searching for the name `paddingLeft`, would be different from reading one with a name of `padding` and a suffix of `Left`. This updates the keying, based on the changes in D51510562. We should refactor this in the future (D20109605, introducing this code, admitted as much). We already have a phase, for aliased props, where we transform input props into the Yoga style (they don't need to be 1:1). This doesn't depend on RawProps, extra props, or prop mutations. Changelog: [Android][Fixed] - Fix AndroidTextInputProps Detection of Padding Reviewed By: GijsWeterings Differential Revision: D51566900
NickGerleman
force-pushed
the
export-D51566900
branch
from
934beeb
to
6fb8941
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51566900 |
|
This pull request has been merged in 4016bfb. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41643 Code in `AndroidTextInputComponentDescriptor` will rewrite Yoga props for padding based on Android theme, if a value isn't supplied. It determines this by adding props in `AndroidTextInputProps` which reads Yoga RawProps to tell if they were set. RawProps are keyed using separate prefix/name/suffix, instead of the combined string name of the prop. This means that searching for the name `paddingLeft`, would be different from reading one with a name of `padding` and a suffix of `Left`. This updates the keying, based on the changes in D51510562. We should refactor this in the future (D20109605, introducing this code, admitted as much). We already have a phase, for aliased props, where we transform input props into the Yoga style (they don't need to be 1:1). This doesn't depend on RawProps, extra props, or prop mutations. Changelog: [Android][Fixed] - Fix AndroidTextInputProps Detection of Padding Reviewed By: GijsWeterings Differential Revision: D51566900 fbshipit-source-id: ca744b23d71382941903da42d86ad3eef7b65de8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Code in
AndroidTextInputComponentDescriptorwill rewrite Yoga props for padding based on Android theme, if a value isn't supplied. It determines this by adding props inAndroidTextInputPropswhich reads Yoga RawProps to tell if they were set.RawProps are keyed using separate prefix/name/suffix, instead of the combined string name of the prop. This means that searching for the name
paddingLeft, would be different from reading one with a name ofpaddingand a suffix ofLeft.This updates the keying, based on the changes in D51510562.
We should refactor this in the future (D20109605, introducing this code, admitted as much). We already have a phase, for aliased props, where we transform input props into the Yoga style (they don't need to be 1:1). This doesn't depend on RawProps, extra props, or prop mutations.
Changelog:
[Android][Fixed] - Fix AndroidTextInputProps Detection of Padding
Differential Revision: D51566900