Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ReactInstancePackage #41095

Closed
wants to merge 6 commits into from
Closed

Delete ReactInstancePackage #41095

wants to merge 6 commits into from

Commits on Oct 25, 2023

  1. Mark ReactInstanceManager and ReactInstanceManagerBuilder as Stable (f… 

    …acebook#41099)

Summary:

Mark ReactInstanceManager and ReactInstanceManagerBuilder as Stable

bypass-github-export-checks

changelog: [internal] internal

Reviewed By: christophpurrer

Differential Revision: D50338305
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    eca5f08 View commit details
    Browse the repository at this point in the history

  2. Migrate ReactInstanceEventListener to kotlin (facebook#41098) 

    Summary:

Migrate ReactInstanceEventListener to kotlin

changelog: [internal] internal

Reviewed By: christophpurrer

Differential Revision: D50338295
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    175c13f View commit details
    Browse the repository at this point in the history

  3. Mark LazyReactPackage as Deprecated in the new architecture of React … 

    …Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f097000 View commit details
    Browse the repository at this point in the history

  4. Delete LazyReactPackage.getReactModuleInfoProviderViaReflection (face… 

    …book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    fff5e1d View commit details
    Browse the repository at this point in the history

  5. Migrate JSEngineResolutionAlgorithm to kotlin (facebook#41015) 

    Summary:

Migrate JSEngineResolutionAlgorithm to kotlin

changelog: [internal] internal

Reviewed By: christophpurrer, cortinico

Differential Revision: D50338298
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c36d719 View commit details
    Browse the repository at this point in the history

  6. Delete ReactInstancePackage (facebook#41095) 

    Summary:

I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used.

changelog: [Android][Breaking] Delete ReactInstancePackage

Reviewed By: christophpurrer

Differential Revision: D50338299
    @mdvacca @facebook-github-bot
    mdvacca authored and facebook-github-bot committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8d9b4b1 View commit details
    Browse the repository at this point in the history