Delete ReactInstancePackage #41095
Closed
Delete ReactInstancePackage #41095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
Base commit: dca81e6 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 20, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
4968ace
to
b4bfb66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 21, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
b4bfb66
to
34959d5
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 21, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
34959d5
to
069bba8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 21, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
2 times, most recently
from
63b7cd4
to
d428596
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 23, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 23, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
d428596
to
f6d5868
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 24, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
f6d5868
to
dc8232d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 24, 2023
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
dc8232d
to
f9f989e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
…acebook#41099) Summary: Mark ReactInstanceManager and ReactInstanceManagerBuilder as Stable bypass-github-export-checks changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D50338305
Summary: Migrate ReactInstanceEventListener to kotlin changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D50338295
…Native (facebook#41097) Summary: LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D50338301
…book#41096) Summary: LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it. There are no usages internally or externally changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection Reviewed By: arushikesarwani94 Differential Revision: D50338302
Summary: Migrate JSEngineResolutionAlgorithm to kotlin changelog: [internal] internal Reviewed By: christophpurrer, cortinico Differential Revision: D50338298
Summary: I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: christophpurrer Differential Revision: D50338299
mdvacca
force-pushed
the
export-D50338299
branch
from
f9f989e
to
8d9b4b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50338299 |
|
This pull request has been merged in 7141c47. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41095 I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: philIip Differential Revision: D50338299 fbshipit-source-id: 2824e58ff3bf9d17b605239dd9c9bea0adba93b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used.
changelog: [Android][Breaking] Delete ReactInstancePackage
Reviewed By: christophpurrer
Differential Revision: D50338299