Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AsyncCallback as noexcept #40745

Closed
wants to merge 1 commit into from
Closed

Conversation

javache
Copy link
Member

@javache javache commented Oct 9, 2023

Summary: Changelog: [Internal]

Differential Revision: D49886196

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49886196

@analysis-bot
Copy link

analysis-bot commented Oct 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,219,064 -8,180
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,587,258 -8,182
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5cec1ea
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49886196

javache added a commit to javache/react-native that referenced this pull request Oct 10, 2023
Summary:
Pull Request resolved: facebook#40745

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D49886196

fbshipit-source-id: 250475a9d2a3449095621a5c39e2e93c842f8574
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49886196

javache added a commit to javache/react-native that referenced this pull request Oct 10, 2023
Summary:
Pull Request resolved: facebook#40745

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D49886196

fbshipit-source-id: 170c2ba4c80a0bf2089cea92ac4a40b1d094743b
Summary:
Pull Request resolved: facebook#40745

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D49886196

fbshipit-source-id: 1ab07d9d76f9b4c22760ac65ca2d0418493dd24a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49886196

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 44f5989.

@javache javache deleted the export-D49886196 branch October 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants