Relax FlatList.onViewableItemsChanged validation #39153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48656586 |
Summary: Pull Request resolved: facebook#39153 `FlatList`'s restriction on not changing the `onViewableItemsChanged` prop forces developers to violate the rules of React, risking bugs and blocking the rollout of other improvements such as React Forget. This diff relaxes the validation specifically for the seemingly common case in which a developer passes just a onViewableItemsChanged prop instead of viewabilityConfigCallbackPairs. We use an anonymous closure to create a stable identity that will be passed down to the underlying VirtualizedList, where the closure calls the current `props.onViewableItemsChanged`. The intent of this diff is to alleviate the worst impacts of the current restriction with a correct if not ideal solution, giving us time to fix the API more holistically. Feedback welcome! ## Changelog: [Changed] - Allow passing different values to `FlatList.onViewableItemsChanged` ## Facebook See https://fburl.com/workplace/9svfrytw for more context. Reviewed By: NickGerleman Differential Revision: D48656586 fbshipit-source-id: 005f946c9ebd3dd5875770f55de8634637444791
|
This pull request was exported from Phabricator. Differential Revision: D48656586 |
josephsavona
force-pushed
the
export-D48656586
branch
from
d679278
to
fbb9096
Compare
|
This pull request has been merged in 5cfa125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FlatList's restriction on not changing theonViewableItemsChangedprop forces developers to violate the rules of React, risking bugs and blocking the rollout of other improvements such as React Forget.This diff relaxes the validation specifically for the seemingly common case in which a developer passes just a onViewableItemsChanged prop instead of viewabilityConfigCallbackPairs. We use an anonymous closure to create a stable identity that will be passed down to the underlying VirtualizedList, where the closure calls the current
props.onViewableItemsChanged. The intent of this diff is to alleviate the worst impacts of the current restriction with a correct if not ideal solution, giving us time to fix the API more holistically.Feedback welcome!
Changelog:
[Changed] - Allow passing different values to
FlatList.onViewableItemsChangedDifferential Revision: D48656586