kill RCTRootViewIntegrationTests #38871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
Summary: Pull Request resolved: facebook#38871 these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Differential Revision: D48179389 fbshipit-source-id: 491d8461464665725dd73118e49c66f3405b1bf1
philIip
force-pushed
the
export-D48179389
branch
from
4f3120e to
b1cee4a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
Base commit: 21e3e2f |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Differential Revision: D48179389 fbshipit-source-id: 5a03dec2bc9fef374c9a4a9978fbd565c5e3faa2
philIip
force-pushed
the
export-D48179389
branch
from
b1cee4a to
885160a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 10, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 4f164c7bf0c593c13d61529ccbeaacb4013ed3f0
philIip
force-pushed
the
export-D48179389
branch
from
885160a to
71b8a75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 350e4be3bec439ebe9648b52dd6bd916e07c39a6
philIip
force-pushed
the
export-D48179389
branch
from
71b8a75 to
cd332d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 25291e2947a541adbb4aee3857fd036b04ba8b83
philIip
force-pushed
the
export-D48179389
branch
from
cd332d9 to
4479fe3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 4d36057e39e34675e5a24dd79c3aa36f54889b7e
philIip
force-pushed
the
export-D48179389
branch
from
4479fe3 to
8ceffcb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 8d4211f85ecca2852fbd4e3e4097edbbcbfbeb7a
philIip
force-pushed
the
export-D48179389
branch
from
8ceffcb to
1c312cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: b75cfbcbc4522c76b9b83f5d078e3f457c373231
philIip
force-pushed
the
export-D48179389
branch
from
1c312cd to
8b66a47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 4c196cef17c47015684bc93f99600e58698dec71
philIip
force-pushed
the
export-D48179389
branch
from
8b66a47 to
d9958a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 5e8477d7da9e14861fa2a356ec99f9feacbdd613
philIip
force-pushed
the
export-D48179389
branch
from
d9958a9 to
24afdc6
Compare
Summary: Pull Request resolved: facebook#38871 Changelog: [Internal] these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them Reviewed By: cipolleschi Differential Revision: D48179389 fbshipit-source-id: 9c71db5fdd1237345d2239e2dff3a64294b940fa
|
This pull request was exported from Phabricator. Differential Revision: D48179389 |
philIip
force-pushed
the
export-D48179389
branch
from
24afdc6 to
6c94daa
Compare
|
This pull request has been merged in 97efa25. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
) Summary: #38871 removed all the RCTRootViewIntegrationTest stuff. Looks like we missed a line so I'm removing now. ## Changelog: [INTERNAL] [FIXED] - Don't load RCTRootViewIntegrationTestsApp.bundle in objc-test.sh Pull Request resolved: #39615 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D49612227 Pulled By: ryancat fbshipit-source-id: c16dcf7bec0bdfa839d250cfa6eadf83d792ae0d
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
…ebook#39615) Summary: facebook#38871 removed all the RCTRootViewIntegrationTest stuff. Looks like we missed a line so I'm removing now. ## Changelog: [INTERNAL] [FIXED] - Don't load RCTRootViewIntegrationTestsApp.bundle in objc-test.sh Pull Request resolved: facebook#39615 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D49612227 Pulled By: ryancat fbshipit-source-id: c16dcf7bec0bdfa839d250cfa6eadf83d792ae0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: these tests are the last callsite where we are getting event emitter off of RCTRootView... these particular tests have been disabled and they're like 8 years old, sooooooo i think it's just easier for me to delete them
Differential Revision: D48179389