Right align scrollToIndex in RTL #38737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47978637 |
Base commit: a34ce64 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 3, 2023
Summary: Pull Request resolved: facebook#38737 This fixes up behavior on Android so that `scrollToIndex` aligns the right edge of the cell of the given index to the right edge of the scrollview viewport. We do not incorporate RTL on iOS which inverts x/y coordinates from scroller (but not layout). Changelog: [General][Fixed] - Right align scrollToIndex in RTL Reviewed By: lenaic Differential Revision: D47978637 fbshipit-source-id: ea75179ccd2034fe4568e7504194ffe7d1a0cedf
NickGerleman
force-pushed
the
export-D47978637
branch
from
655171a
to
3924a7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978637 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 4, 2023
Summary: Pull Request resolved: facebook#38737 This fixes up behavior on Android so that `scrollToIndex` aligns the right edge of the cell of the given index to the right edge of the scrollview viewport. We do not incorporate RTL on iOS which inverts x/y coordinates from scroller (but not layout). Changelog: [General][Fixed] - Right align scrollToIndex in RTL Reviewed By: lenaic Differential Revision: D47978637 fbshipit-source-id: 638de1ab47bfa034190789d8564fafec7a17630c
NickGerleman
force-pushed
the
export-D47978637
branch
from
3924a7c
to
4af98bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978637 |
Summary: Returned measurements from the measurements cache in RTL calculate offset as distance from the left edge of the cell to the right edge of the content, when it should instead be the distance from the right edge of the cell (the logical beginning). Changelog: [General][Fixed] - Return right edge in RTL cell metrics Differential Revision: D47978631 fbshipit-source-id: 70eb23ea2578c164832cc9f2efb060b56b10fc00
Summary: Pull Request resolved: facebook#38737 This fixes up behavior on Android so that `scrollToIndex` aligns the right edge of the cell of the given index to the right edge of the scrollview viewport. We do not incorporate RTL on iOS which inverts x/y coordinates from scroller (but not layout). Changelog: [General][Fixed] - Right align scrollToIndex in RTL Reviewed By: lenaic Differential Revision: D47978637 fbshipit-source-id: c4a37e5864f80f1750c394f9ce8a47db735a49a8
NickGerleman
force-pushed
the
export-D47978637
branch
from
4af98bf
to
0949fa6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978637 |
|
This pull request has been merged in 5596f1c. |
mmmoussa
reviewed
Dec 28, 2023
| }); | ||
| } | ||
|
|
||
| _scrollToParamsFromOffset(offset: number): {x?: number, y?: number} { | ||
| const {horizontal, rtl} = this._orientation(); | ||
| if (horizontal && rtl) { |
There was a problem hiding this comment.
This change broke lists in our iOS app in RTL. We heavily rely on horizontal lists and ship to both iOS and Android in LTR and RTL. This line should've been if (horizontal && rtl && Platform.OS !== 'ios') {. We tested that fix in our app and that has resolved things for us. @NickGerleman is Meta using large horizontal lists in any part of its localized RN surfaces? If so, is there something I'm missing here?
There was a problem hiding this comment.
Able to repro native scrollTo not using right coordinate space on iOS old arch. New arch has different scrollview component, and seems to be doing the right thing.
There are a good number of changes since this one, but there was an effort to get all the events/platforms onto consistent coordinate spaces. So, no "if iOS, on Paper, do opposite".
I can make quick PR to try to fix this.
There was a problem hiding this comment.
Try out this change: https://github.com/facebook/react-native/pull/42094/files
There was a problem hiding this comment.
Can confirm that change also fixes it
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Dec 29, 2023
Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Differential Revision: D52451602
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Dec 29, 2023
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Differential Revision: D52451602
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 3, 2024
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 3, 2024
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horiozntal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 3, 2024
…facebook#42094) Summary: Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
…#42094) Summary: Pull Request resolved: #42094 Fabric fixed this a while back with 9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. #38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602 fbshipit-source-id: f41d8248c7f6ab23965800b09ca1082fd1a15151
huntie
pushed a commit
that referenced
this pull request
Jan 3, 2024
…#42094) Summary: Pull Request resolved: #42094 Fabric fixed this a while back with 9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. #38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602 fbshipit-source-id: f41d8248c7f6ab23965800b09ca1082fd1a15151
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…facebook#42094) Summary: Pull Request resolved: facebook#42094 Fabric fixed this a while back with facebook@9ca460f Looks like this is still broken on Paper, and now VirtualizedList relies on it. facebook#38737 (comment) Changelog: [ios][fixed] - Fix horizontal scrollview scrollTo coordinate space in RTL on oldarch Reviewed By: lenaic Differential Revision: D52451602 fbshipit-source-id: f41d8248c7f6ab23965800b09ca1082fd1a15151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes up behavior on Android so that
scrollToIndexaligns the right edge of the cell of the given index to the right edge of the scrollview viewport. We do not incorporate RTL on iOS which inverts x/y coordinates from scroller (but not layout).Changelog:
[General][Fixed] - Right align scrollToIndex in RTL
Differential Revision: D47978637