-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use pod install --project-directory
when testing template
#37996
Conversation
09ed06e
to
62ad520
Compare
Base commit: eaafc26 |
Seems to be failing as expected: I'll rebase when #37992 lands. |
62ad520
to
09044fc
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing this will run the pod install command for ALL the template tests from the parent directory.
Could there be a scenario where this works but running pod install
from the ios
folder (i.e.: without the --project-directory
parameter) fails?
In other words, if we proceed with this, could we end up breaking pod install
from ios
?
My gut says no, as using --project-directory
seems like a more general case than running pod install
from a specific folder, but I think it's worth double-checking.
(requesting change to discuss the point above, mainly) |
/rebase |
09044fc
to
6b938c7
Compare
I haven't run through all possible cases, but for what it's worth, we've always used this in RNTA and have not encountered a case where |
Yeah, I supposed that that was the case. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase |
6b938c7
to
2e108c8
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @tido64 in e1fd4a8. When will my fix make it into a release? | Upcoming Releases |
@cipolleschi merged this pull request in e1fd4a8. |
Summary:
Exercise
pod install --project-directory=ios
when building the generated iOS project to make sure we don't regress in the future.See also #37992, #35754, #34215, #33909…
Changelog:
[INTERNAL] [ADDED] - Exercise
pod install --project-directory=ios
when testing the iOS templateTest Plan:
CI should pass.