Use fileExists in replace_hermes script
#37911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46762041 |
Summary: Pull Request resolved: facebook#37911 Thanks to [adrianha](https://github.com/adrianha) for spotting a bug in the script that replace the Hermes engine. I miscopied the variable to check when there is no previous build file. This change uses the right variable and improves also the messages printed to the user. ## Changelog: [Internal] - Fix replace_hermes_version script using the right `fileExists` variable Reviewed By: dmytrorykun Differential Revision: D46762041 fbshipit-source-id: 8a0ed91349575e2b994613eb763f79e4318486ed
cipolleschi
force-pushed
the
export-D46762041
branch
from
ef291a1 to
888b6ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46762041 |
Base commit: 7d4f233 |
|
This pull request was successfully merged by @cipolleschi in 09c9541. When will my fix make it into a release? | Upcoming Releases |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Thanks to adrianha for spotting a bug in the script that replace the Hermes engine.
I miscopied the variable to check when there is no previous build file.
This change uses the right variable and improves also the messages printed to the user.
Changelog:
[Internal] - Fix replace_hermes_version script using the right
fileExistsvariableDifferential Revision: D46762041