Fix component type references in xplat #37903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 446c3e752e3d3841e2ce7649c7eae61ebd468e14
pieterv
force-pushed
the
export-D46748791
branch
from
8130528 to
70b3b03
Compare
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 76e304aca202f627b4b51fff7607ca5b9fa28b61
pieterv
force-pushed
the
export-D46748791
branch
from
70b3b03 to
7d5d24b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 3a5d36ebd59707b8c4786c95066a5ec6337a9bea
pieterv
force-pushed
the
export-D46748791
branch
from
7d5d24b to
51a9765
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
Base commit: 8c9e375 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 0300ce24dabc7d36335354e667ec50fc1c7127cb
pieterv
force-pushed
the
export-D46748791
branch
from
51a9765 to
7748927
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
pieterv
added a commit
to pieterv/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 439a6b6a3e1f9eec5d661bbfb2cb3c630c0ea49c
pieterv
force-pushed
the
export-D46748791
branch
from
7748927 to
f64f8db
Compare
Summary: Pull Request resolved: facebook#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 65994bc97d4930406b5e0b6a286d7fe08be8ff4a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46748791 |
pieterv
force-pushed
the
export-D46748791
branch
from
f64f8db to
d542f00
Compare
Contributor
|
This pull request has been merged in 894b62c. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D46748791