Skip to content

Re-enable direct debugging with JSC on iOS 16.4+ #37874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Saadnajmi wants to merge 2 commits into from
Closed

Re-enable direct debugging with JSC on iOS 16.4+ #37874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5141239
Re-enable direct debugging with JSC on iOS 16.4+
Saadnajmi Jun 14, 2023
2bf4348
Update packages/react-native/ReactCommon/jsc/JSCRuntime.cpp
Saadnajmi Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native/ReactCommon/jsc/JSCRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)
stringCounter_(0)
#endif
{
#ifndef NDEBUG
if (__builtin_available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {
Copy link
Contributor

@cipolleschi cipolleschi Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is breaking CircleCI. I don't think __builtin_available is available for Android, and what's in ReactCommon is built by both the platform. cc. @cortinico, I think we have to revert this.

Copy link
Member

@huntie huntie Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #37914 which re-applies this commit with a speculative fix.

Copy link
Contributor

@cortinico cortinico Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging. Yes this needs specific Android handling

Copy link
Contributor Author

@Saadnajmi Saadnajmi Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Didn't realize this was used by Android, thanks all for catching!

JSGlobalContextSetInspectable(ctx_, true);
}
#endif
}

JSCRuntime::~JSCRuntime() {
Expand Down