Back out "When animating using native driver, trigger rerender on animation completion" #37820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46629553 |
Base commit: d71da61 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Jun 12, 2023
…mation completion" (facebook#37820) Summary: Pull Request resolved: facebook#37820 Original commit changeset: 185471b28f5f Original Phabricator Diff: D46574511 The original diff may have broken several E2E tests: - https://www.internalfb.com/intern/test/281475053258471/ - https://www.internalfb.com/intern/test/562950042062069/ - https://www.internalfb.com/intern/test/281475065342188/ - https://www.internalfb.com/intern/test/844425018778537/ Errors come from: https://www.internalfb.com/code/fbsource/[79ff1b109432c02b756d4fea6e7a66ff21e34be6]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=89 Reviewed By: jehartzog Differential Revision: D46629553 fbshipit-source-id: b4fac49ef42ce07f6dcf83acb2691b81072f79fb
genkikondo
force-pushed
the
export-D46629553
branch
from
708edb0
to
8ddc8dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46629553 |
…mation completion" (facebook#37820) Summary: Pull Request resolved: facebook#37820 Original commit changeset: 185471b28f5f Original Phabricator Diff: D46574511 Changelog: [internal] Reviewed By: jehartzog Differential Revision: D46629553 fbshipit-source-id: 3ce97311d209603a9aba0d6d58fce2fa7fc8ac2a
|
This pull request was exported from Phabricator. Differential Revision: D46629553 |
genkikondo
force-pushed
the
export-D46629553
branch
from
8ddc8dc
to
e725c64
Compare
|
This pull request has been merged in 48cdc60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 185471b28f5f
Original Phabricator Diff: D46574511
The original diff may have broken several E2E tests:
Errors come from: https://www.internalfb.com/code/fbsource/[79ff1b109432c02b756d4fea6e7a66ff21e34be6]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=89
Differential Revision: D46629553