[Codegen 124] Create emitStringProp function

[cloudpresser]

Summary:

Create a function emitStringProp(name: string, optional: boolean) in parser-primitives.js. Factor out the code from Flow and TypeScript into that function. Use that function in the original call site.

Changelog:

[INTERNAL][ADDED] - emitStringProp in parser-primitves

Test Plan:

yarn jest packages/react-native-codegen

[facebook-github-bot]

Hi @cloudpresser!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,732,789	-654
android	hermes	armeabi-v7a	8,043,973	-648
android	hermes	x86	9,222,896	-652
android	hermes	x86_64	9,074,872	-646
android	jsc	arm64-v8a	9,297,696	-501
android	jsc	armeabi-v7a	8,486,442	-487
android	jsc	x86	9,358,864	-493
android	jsc	x86_64	9,614,958	-486

Base commit: 133ccdc
Branch: main

[Pranav-yadav]

Hi @cloudpresser, 👋

Congratulations 🎉 on your "First Pull Request" to React Native! 🥳

Thank you, 🙏 for taking the time to contribute to this project and share your ideas.

Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳

P.S.: In the meantime, you should go through below checklist: ^{(click to expand)}

1. Make sure you have signed the CLA 📃🙂,
2. There are no typos 😄,
3. All tests 🧪 are passing. i.e. The CI checks should be green 🟢, and
4. You have added necessary tests for your code, if it's a refactor or a new functionality. 🧪

---

Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[cipolleschi]

Amazing @cloudpresser! Thanks for this contribution!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 7062398.