-
Notifications
You must be signed in to change notification settings - Fork 25k
[Actions] Add greet action 🎉 #37499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] Add greet action 🎉 #37499
Conversation
Base commit: 670fa88 |
7d40b48 to
456f1a9
Compare
|
@SlyCaptainFlint Take a look at this whenever you get time. (P.S. mentioned you since you recently refctored other actions) Example of greet message (though, not added by this action):
Cc: @cortinico WDYT? 🙂 |
|
This week we've seen a lot of "First Time Contributors" Cc: @cipolleschi do you think having this action would benefit...? |
The only thing I would add is a note to check what Danger is reporting, as people tend to ignore it. Other than that, I believe we're good to go 👍 |
2e37127 to
4812877
Compare
Done. |
cipolleschi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I personally love that, as it may save us some repetitive messaging!
I left a small comment, which I am not super sure about too, tbh. XD
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This action (`greet.yml`) should greet the "First Time Contributors" 🎉 w/ some guidelines and informative links. -- w/ ❤️ from @Pranav-yadav & 🐨
4812877 to
735f303
Compare
Done. 🚀🤞 |
|
@cipolleschi merged this pull request in 1671247. |
|
@cipolleschi looks like you didn't import the latest changes, so the merged commit still has those |
Summary:
Currently we do not greet; "First Time Contributors".
It is important to greet every first time contributor keep the OSS community thriving. 😊
This PR; Adds a greet action
greet.yml🎉, which comments under First Time Contributors PRs, greeting them as well suggesting some basic steps/guidelines.Changelog:
[GENERAL] [ADDED] - [Actions] Add greet action 🎉
Test Plan: