Skip to content

Conversation

@Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented May 20, 2023

Summary:

Currently we do not greet; "First Time Contributors".
It is important to greet every first time contributor keep the OSS community thriving. 😊

This PR; Adds a greet action greet.yml 🎉, which comments under First Time Contributors PRs, greeting them as well suggesting some basic steps/guidelines.

Changelog:

[GENERAL] [ADDED] - [Actions] Add greet action 🎉

Test Plan:

  • Should greet 1st time contributors

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2023
@analysis-bot
Copy link

analysis-bot commented May 20, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,739,374 -5
android hermes armeabi-v7a 8,050,270 -3
android hermes x86 9,229,565 -3
android hermes x86_64 9,081,391 -5
android jsc arm64-v8a 9,302,718 -5
android jsc armeabi-v7a 8,491,193 -5
android jsc x86 9,363,973 -4
android jsc x86_64 9,619,913 -4

Base commit: 670fa88
Branch: main

@Pranav-yadav Pranav-yadav force-pushed the Pranav-yadav/greet-action branch 2 times, most recently from 7d40b48 to 456f1a9 Compare May 20, 2023 11:04
@Pranav-yadav Pranav-yadav marked this pull request as ready for review May 20, 2023 11:09
@Pranav-yadav
Copy link
Contributor Author

@SlyCaptainFlint Take a look at this whenever you get time. (P.S. mentioned you since you recently refctored other actions)

Example of greet message (though, not added by this action):
#37488 (comment)

  1. What else do we need to add in the greet message? (I would say; short, simple & sweet 😊)
  2. Do we need to mention the contributor ? (FYI: This would add extra complexity)
  3. What should be removed from current message?

Cc: @cortinico WDYT? 🙂

@Pranav-yadav
Copy link
Contributor Author

This week we've seen a lot of "First Time Contributors"
Chain React 👍

Cc: @cipolleschi do you think having this action would benefit...?

@cortinico
Copy link
Contributor

  1. What else do we need to add in the greet message? (I would say; short, simple & sweet 😊)

The only thing I would add is a note to check what Danger is reporting, as people tend to ignore it. Other than that, I believe we're good to go 👍

@Pranav-yadav Pranav-yadav force-pushed the Pranav-yadav/greet-action branch 2 times, most recently from 2e37127 to 4812877 Compare May 23, 2023 17:05
@Pranav-yadav
Copy link
Contributor Author

  1. What else do we need to add in the greet message? (I would say; short, simple & sweet 😊)

The only thing I would add is a note to check what Danger is reporting, as people tend to ignore it. Other than that, I believe we're good to go 👍

Done.
P.S. I'm not used to multiline strings syntax of yaml especially in actions so, may be you can validate; if it'll work with proper formatting on GitHub.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I personally love that, as it may save us some repetitive messaging!

I left a small comment, which I am not super sure about too, tbh. XD

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This action (`greet.yml`) should greet the "First Time Contributors" 🎉
w/ some guidelines and informative links.

-- w/ ❤️ from @Pranav-yadav & 🐨
@Pranav-yadav Pranav-yadav force-pushed the Pranav-yadav/greet-action branch from 4812877 to 735f303 Compare May 24, 2023 11:06
@Pranav-yadav
Copy link
Contributor Author

Pranav-yadav commented May 24, 2023

I think that, with the | operator, we can remove the " at the beginning and end of the string.

Sure. Let's go with your suggestion. 😉👍
I hope the 1st contributor seeing this in action will be happy and most importantly, the msg formatting will be proper.

Done. 🚀🤞

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 24, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 1671247.

@Pranav-yadav Pranav-yadav deleted the Pranav-yadav/greet-action branch May 24, 2023 12:42
@Pranav-yadav
Copy link
Contributor Author

@cipolleschi looks like you didn't import the latest changes, so the merged commit still has those "s 🙂

@Pranav-yadav Pranav-yadav restored the Pranav-yadav/greet-action branch May 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants