Skip to content

Codegen 123: add parser-primitive function for emitBoolProp #37488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Codegen 123: add parser-primitive function for emitBoolProp #37488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5a7122
add parser-primitive function for emitting bool prop
frankcalise May 19, 2023
1254a01
import fix
frankcalise May 19, 2023
c3aec0e
require in favor of import
frankcalise May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions packages/react-native-codegen/src/parsers/__tests__/parsers-primitives-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import type {UnionTypeAnnotationMemberType} from '../../CodegenSchema';
const {
emitArrayType,
emitBoolean,
emitBoolProp,
emitDouble,
emitFloat,
emitNumber,
Expand Down Expand Up @@ -829,7 +830,7 @@ describe('emitUnion', () => {
'ObjectTypeAnnotation',
];
describe('when nullable is true', () => {
it('throws an excpetion', () => {
it('throws an exception', () => {
const expected = new UnsupportedUnionTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
Expand All @@ -843,7 +844,7 @@ describe('emitUnion', () => {
});

describe('when nullable is false', () => {
it('throws an excpetion', () => {
it('throws an exception', () => {
const expected = new UnsupportedUnionTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
Expand Down Expand Up @@ -1042,7 +1043,7 @@ describe('emitUnion', () => {
'ObjectTypeAnnotation',
];
describe('when nullable is true', () => {
it('throws an excpetion', () => {
it('throws an exception', () => {
const expected = new UnsupportedUnionTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
Expand All @@ -1056,7 +1057,7 @@ describe('emitUnion', () => {
});

describe('when nullable is false', () => {
it('throws an excpetion', () => {
it('throws an exception', () => {
const expected = new UnsupportedUnionTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
Expand Down Expand Up @@ -1506,3 +1507,34 @@ describe('emitCommonTypes', () => {
});
});
});

describe('emitBoolProp', () => {
describe('when optional is true', () => {
it('returns optional type annotation', () => {
const result = emitBoolProp('someProp', true);
const expected = {
name: 'someProp',
optional: true,
typeAnnotation: {
type: 'BooleanTypeAnnotation',
},
};

expect(result).toEqual(expected);
});
});
describe('when optional is false', () => {
it('returns required type annotation', () => {
const result = emitBoolProp('someProp', false);
const expected = {
name: 'someProp',
optional: false,
typeAnnotation: {
type: 'BooleanTypeAnnotation',
},
};

expect(result).toEqual(expected);
});
});
});
10 changes: 3 additions & 7 deletions packages/react-native-codegen/src/parsers/flow/components/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ import type {
EventTypeAnnotation,
} from '../../../CodegenSchema.js';
import type {Parser} from '../../parser';

const {
throwIfEventHasNoName,
throwIfBubblingTypeIsNull,
throwIfArgumentPropsAreNull,
} = require('../../error-utils');
const {getEventArgument} = require('../../parsers-commons');
const {emitBoolProp} = require('../../parsers-primitives');

function getPropertyType(
/* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
Expand All @@ -35,13 +37,7 @@ function getPropertyType(

switch (type) {
case 'BooleanTypeAnnotation':
return {
name,
optional,
typeAnnotation: {
type: 'BooleanTypeAnnotation',
},
};
return emitBoolProp(name, optional);
case 'StringTypeAnnotation':
return {
name,
Expand Down
16 changes: 16 additions & 0 deletions packages/react-native-codegen/src/parsers/parsers-primitives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import type {
VoidTypeAnnotation,
NativeModuleObjectTypeAnnotation,
NativeModuleEnumDeclaration,
NamedShape,
EventTypeAnnotation,
} from '../CodegenSchema';
import type {Parser} from './parser';
import type {
Expand Down Expand Up @@ -577,9 +579,23 @@ function emitCommonTypes(
);
}

function emitBoolProp(
name: string,
optional: boolean,
): NamedShape<EventTypeAnnotation> {
return {
name,
optional,
typeAnnotation: {
type: 'BooleanTypeAnnotation',
},
};
}

module.exports = {
emitArrayType,
emitBoolean,
emitBoolProp,
emitDouble,
emitFloat,
emitFunction,
Expand Down
10 changes: 3 additions & 7 deletions packages/react-native-codegen/src/parsers/typescript/components/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ const {
throwIfArgumentPropsAreNull,
} = require('../../error-utils');
const {getEventArgument} = require('../../parsers-commons');
const {emitBoolProp} = require('../../parsers-primitives');

function getPropertyType(
/* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
* LTI update could not be added via codemod */
Expand All @@ -45,13 +47,7 @@ function getPropertyType(

switch (type) {
case 'TSBooleanKeyword':
return {
name,
optional,
typeAnnotation: {
type: 'BooleanTypeAnnotation',
},
};
return emitBoolProp(name, optional);
case 'TSStringKeyword':
return {
name,
Expand Down