Skip to content

Conversation

@frankcalise
Copy link
Collaborator

Summary:

Part of #34872, Improving Codegen

Reduces code duplication by creating a helper function emitBoolProp(name: string, optional: boolean) in parser-primitives.js. Refactors the code from Flow and TypeScript to utilize the new function.

Changelog:

Test Plan:

Run yarn jest react-native-codegen

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2023
@Pranav-yadav
Copy link
Contributor

Hi @frankcalise, 👋

Congratulations 🎉 on your "First Pull Request" to React Native! 🥳

Thank you, 🙏 for taking the time to contribute to this project and share your ideas.

Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳

P.S.: In the meantime, you should go through below checklist: (click to expand)
  1. Make sure you have signed the CLA 📃🙂,
  2. There are no typos 😄,
  3. All tests 🧪 are passing. i.e. The CI checks should be green 🟢, and
  4. You have added necessary tests for your code, if it's a refactor or a new functionality. 🧪

Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label May 20, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,657 -329
android hermes armeabi-v7a 8,043,843 -326
android hermes x86 9,222,768 -316
android hermes x86_64 9,074,743 -318
android jsc arm64-v8a 9,297,416 -467
android jsc armeabi-v7a 8,486,153 -484
android jsc x86 9,358,582 -474
android jsc x86_64 9,614,669 -481

Base commit: f8a1f62
Branch: main

@frankcalise frankcalise marked this pull request as ready for review May 20, 2023 13:43
@frankcalise
Copy link
Collaborator Author

@Pranav-yadav this officially got assigned by @cipolleschi. Apologies for the pre-emptive PR, will wait for proper assignment next time

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful to see your first contribution @frankcalise! Great job here!

@cipolleschi cipolleschi added the p: Infinite Red Partner: Infinite Red label May 22, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

/rebase

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 66f4a91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Infinite Red Partner: Infinite Red Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants