-
Notifications
You must be signed in to change notification settings - Fork 25k
Codegen 123: add parser-primitive function for emitBoolProp #37488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/react-native-codegen/src/parsers/__tests__/parsers-primitives-test.js
Show resolved
Hide resolved
Hi @frankcalise, 👋Congratulations 🎉 on your "First Pull Request" to React Native! 🥳Thank you, 🙏 for taking the time to contribute to this project and share your ideas. Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳 P.S.: In the meantime, you should go through below checklist: (click to expand)
Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs |
Base commit: f8a1f62 |
|
@Pranav-yadav this officially got assigned by @cipolleschi. Apologies for the pre-emptive PR, will wait for proper assignment next time |
cipolleschi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful to see your first contribution @frankcalise! Great job here!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 66f4a91. |
Summary:
Part of #34872, Improving Codegen
Reduces code duplication by creating a helper function
emitBoolProp(name: string, optional: boolean)inparser-primitives.js. Refactors the code from Flow and TypeScript to utilize the new function.Changelog:
Test Plan:
Run
yarn jest react-native-codegen