Modify ViewManager.receiveCommand to call into delegate #37070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45236213 |
Base commit: 5e983d5 |
Summary: Pull Request resolved: facebook#37070 This diff fixes an issue where codegened native commands are not able to be triggered, as codegen adds command handling to the delegate. This also brings how receiveCommand is handled into parity with how setProperties is called on the delegate. Changelog: [Fixed][Android] - Modify ViewManager.receiveCommand to call into delegate Reviewed By: javache Differential Revision: D45236213 fbshipit-source-id: 241c678dadee16e2a371641c15b9556a92ee9238
|
This pull request was exported from Phabricator. Differential Revision: D45236213 |
genkikondo
force-pushed
the
export-D45236213
branch
from
e8127a3
to
a013ed6
Compare
|
This pull request has been merged in 585057d. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37070 This diff fixes an issue where codegened native commands are not able to be triggered, as codegen adds command handling to the delegate. This also brings how receiveCommand is handled into parity with how setProperties is called on the delegate. Changelog: [Fixed][Android] - Modify ViewManager.receiveCommand to call into delegate Reviewed By: javache Differential Revision: D45236213 fbshipit-source-id: 78f232f288f0a9c5f444e680a9cc49dca1d6af9b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37070 This diff fixes an issue where codegened native commands are not able to be triggered, as codegen adds command handling to the delegate. This also brings how receiveCommand is handled into parity with how setProperties is called on the delegate. Changelog: [Fixed][Android] - Modify ViewManager.receiveCommand to call into delegate Reviewed By: javache Differential Revision: D45236213 fbshipit-source-id: 78f232f288f0a9c5f444e680a9cc49dca1d6af9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff fixes an issue where codegened native commands are not able to be triggered, as codegen adds command handling to the delegate. This also brings how receiveCommand is handled into parity with how setProperties is called on the delegate.
Changelog:
[Fixed][Android] - Modify ViewManager.receiveCommand to call into delegate
Differential Revision: D45236213