Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable animating transform matrix #36935

Closed
wants to merge 1 commit into from

Conversation

genkikondo
Copy link
Contributor

Summary:
With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.isAnimatedObjectEnabled is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Differential Revision: D45055381

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45055381

@analysis-bot
Copy link

analysis-bot commented Apr 17, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,719 +246
android hermes armeabi-v7a 7,933,403 +251
android hermes x86 9,106,730 +254
android hermes x86_64 8,961,522 +247
android jsc arm64-v8a 9,186,920 +67
android jsc armeabi-v7a 8,377,212 +59
android jsc x86 9,244,515 +68
android jsc x86_64 9,503,008 +78

Base commit: 7495883
Branch: main

genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Differential Revision: D45055381

fbshipit-source-id: 66bb3ee37922b2ad1ee33d628f95020f43fb33f6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45055381

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45055381

genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Differential Revision: D45055381

fbshipit-source-id: 76cc0af2cf13c829d48cde3e4431d120be9e0f35
genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45055381

fbshipit-source-id: c1955f97b22a9f8873242cd494fa6a0a1df1b955
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45055381

Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45055381

fbshipit-source-id: c0bad995b255142ab8e420e9d5c9bd48bc9db540
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45055381

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4934cdb.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45055381

fbshipit-source-id: 1b9224c0603ca7e89cd6f220d38a4579a4722e02
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36935

With the addition of AnimatedObject, animating prop values with arbitrary map/array nestings are possible (including transform matrix).

Note: this is only enabled when ReactNativeFeatureFlags.useAnimatedObjectForTransform is true.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45055381

fbshipit-source-id: 1b9224c0603ca7e89cd6f220d38a4579a4722e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants