Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable animating skew in transforms with native driver #36933

Closed
wants to merge 3 commits into from

Conversation

genkikondo
Copy link
Contributor

Summary:
Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Differential Revision: D45053914

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45053914

@analysis-bot
Copy link

analysis-bot commented Apr 17, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,536 -251
android hermes armeabi-v7a 7,933,207 -259
android hermes x86 9,106,539 -254
android hermes x86_64 8,961,339 -256
android jsc arm64-v8a 9,186,832 -11
android jsc armeabi-v7a 8,377,122 -14
android jsc x86 9,244,421 -24
android jsc x86_64 9,502,902 -14

Base commit: 145af9a
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45053914

genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36933

Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Differential Revision: D45053914

fbshipit-source-id: 0532815b9d42122b6f4471450506233abdf5dc12
genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36933

Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45053914

fbshipit-source-id: 4b2d494e0403a4419d436aaeeae01095d0bbb27b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45053914

genkikondo and others added 3 commits April 17, 2023 15:10
Differential Revision: D45055855

fbshipit-source-id: 50431691d3aa57c2e7ff68dc0a29a8812f33e15b
Differential Revision: D45055381

fbshipit-source-id: 7b3e212f1a65e08556d22c0fad9430b8332da4b2
Summary:
Pull Request resolved: facebook#36933

Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45053914

fbshipit-source-id: b9431c28791956085ed6f9bb90d49d4569b86cf7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45053914

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 645b643.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36933

Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45053914

fbshipit-source-id: 31198c35eeb55211a3ff88c968707db65b025f49
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36933

Skew is already supported on the platform side; there's no reason to disable animating it.

Changelog:
[General][Added] - Enable animating skew in transforms with native driver

Reviewed By: mdvacca

Differential Revision: D45053914

fbshipit-source-id: 31198c35eeb55211a3ff88c968707db65b025f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants