Deprecate and mark for removal com.facebook.react.common.StandardCharsets #36779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44592721 |
Base commit: efef8eb |
|
This pull request was exported from Phabricator. Differential Revision: D44592721 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 3, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: e246766142c8634eb4897d24b0ffe58732947fd4
mdvacca
force-pushed
the
export-D44592721
branch
from
11eeabe to
a7b8985
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44592721 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 3, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: 8319f04a0dedca339955686363d903330f936efa
mdvacca
force-pushed
the
export-D44592721
branch
from
a7b8985 to
6001bc1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44592721 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 4, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: 08b55c05374db51d50e8faf20c736851674b423d
mdvacca
force-pushed
the
export-D44592721
branch
from
6001bc1 to
69821aa
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 4, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: f7e2237325cf7cd42a66c0bbf14ab54ec1d03c7b
Summary: Pull Request resolved: facebook#36749 Reduce visibility of FabricSoLoader This is a breaking change, but nobody should be using this class Changelog: [internal] internal Reviewed By: javache, cortinico Differential Revision: D44153451 fbshipit-source-id: e487d89f75bdc8d85522d2ca2aec0c14835b8dde
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: 7fdec13e88c37870ffe8b442fc2b7385a38ffd44
|
This pull request was exported from Phabricator. Differential Revision: D44592721 |
mdvacca
force-pushed
the
export-D44592721
branch
from
42e0f17 to
02decd0
Compare
|
This pull request has been merged in c0b4883. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: c3f4286766209a733b466d19dc36891f12d69be1
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…sets (facebook#36779) Summary: Pull Request resolved: facebook#36779 Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+ As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets Changelog: [Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead Reviewed By: rshest Differential Revision: D44592721 fbshipit-source-id: c3f4286766209a733b466d19dc36891f12d69be1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Deprecate and mark for removal com.facebook.react.common.StandardCharsets, this class was originally created because java.nio.charset.StandardCharsets only exists in Android API level 19+
As part of this diff I also migrate all internal usages of com.facebook.react.common.StandardCharsets
Changelog:
[Android][Deprecated] - Deprecate and mark for removal com.facebook.react.common.StandardCharsets, please use java.nio.charset.StandardCharsets instead
Reviewed By: rshest
Differential Revision: D44592721