Introduce AnimatedObject JS node #36688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44279594 |
react-native-bot
added
the
Type: Enhancement
Base commit: 6403363 |
|
This pull request was exported from Phabricator. Differential Revision: D44279594 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Differential Revision: D44279594 fbshipit-source-id: 3ba28441d207071a3d4314238fcbfc70913cb321
genkikondo
force-pushed
the
export-D44279594
branch
from
baba247
to
c9810c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44279594 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Differential Revision: D44279594 fbshipit-source-id: dc1b0696c291bae7fb6f0ef4319a0443911a1172
genkikondo
force-pushed
the
export-D44279594
branch
from
c9810c3
to
22a6a90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44279594 |
genkikondo
force-pushed
the
export-D44279594
branch
from
22a6a90
to
e327cda
Compare
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Differential Revision: D44279594 fbshipit-source-id: 0be0cfa7782bc95c846a2055d18fb521fd8ab0b5
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Reviewed By: rshest Differential Revision: D44279594 fbshipit-source-id: 0b0cfdfe4f49a520c66cded1ad1565aba0466485
|
This pull request was exported from Phabricator. Differential Revision: D44279594 |
genkikondo
force-pushed
the
export-D44279594
branch
from
e327cda
to
3642463
Compare
|
This pull request has been merged in d0fcd43. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Reviewed By: rshest Differential Revision: D44279594 fbshipit-source-id: 9504d841dc9196e51d09a0247601de4d4f991a49
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36688 AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field. I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway. Changelog: [Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values Reviewed By: rshest Differential Revision: D44279594 fbshipit-source-id: 9504d841dc9196e51d09a0247601de4d4f991a49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AnimatedObject is a more generic version of AnimatedTransform, able to handle animated values within arrays and objects. This is useful for props of native components that may need to be animated per field.
I considered flattening the node graph by removing AnimatedStyle and AnimatedTransform. However, this would add significant complexity in AnimatedProps because prop and style values depend on being submitted together on an animation tick (such as transform) using native driver; also, we'll have to special case style anyway.
Changelog:
[Internal][Added] - Introduce AnimatedObject JS node for handling array and object prop values
Differential Revision: D44279594