Calculate entered/exited views during handling of all MotionEvents #36666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44426524 |
|
Base commit: d0fcd43 |
|
This pull request was exported from Phabricator. Differential Revision: D44426524 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 27, 2023
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Differential Revision: D44426524 fbshipit-source-id: fb2e7f1c6d1276cff7d09b9450969ad0e667526e
genkikondo
force-pushed
the
export-D44426524
branch
from
f59d373
to
b16808f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44426524 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 30, 2023
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Differential Revision: D44426524 fbshipit-source-id: 2251392ea4a090199c5eb75a4fc0767aee971055
genkikondo
force-pushed
the
export-D44426524
branch
from
b16808f
to
22ebaea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44426524 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Mar 31, 2023
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Reviewed By: javache Differential Revision: D44426524 fbshipit-source-id: 67b7f972fca85350f7b14466458e670c335b2f1c
genkikondo
force-pushed
the
export-D44426524
branch
from
22ebaea
to
cdc1fa3
Compare
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Reviewed By: javache, mdvacca Differential Revision: D44426524 fbshipit-source-id: f8765ae90f13cd5ebf98680ae6af54e789274ce2
|
This pull request was exported from Phabricator. Differential Revision: D44426524 |
genkikondo
force-pushed
the
export-D44426524
branch
from
cdc1fa3
to
f546482
Compare
|
This pull request has been merged in 47149d2. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Reviewed By: javache, mdvacca Differential Revision: D44426524 fbshipit-source-id: 5225c54c2c995440ac766c6fbc99c08f05c70a92
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#36666) Summary: Pull Request resolved: facebook#36666 Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with [how touch events are handled in iOS](https://www.internalfb.com/code/fbsource/[cdfd2520a4d43b3a46104ecbf437bb792460e3f7]/xplat/js/react-native-github/packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm?lines=780). handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent(). Changelog: [Internal] - Calculate entered/exited views on all touch/move events Reviewed By: javache, mdvacca Differential Revision: D44426524 fbshipit-source-id: 5225c54c2c995440ac766c6fbc99c08f05c70a92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Modify JSPointerDispatcher to dispatch out/over/leave/enter events on handing of any MotionEvent. This functionality is in parity with how touch events are handled in iOS.
handleMotionEvent updates the last hit path upon any MotionEvent, so we want to make sure that we handle any out/over/leave/enter dispatches in this method. This diff just extracts the dispatching of out/over/leave/enter from onMove() to handleMotionEvent().
Differential Revision: D44426524