Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update publishing packages tag message prefix #36348

Closed
wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Mar 1, 2023

Summary:
Changelog: [Internal]

Turns out that Phabricator strips @ symbol from @... tags when exports commits to GitHub. Proposing to use # instead.

#publish-packages-to-npm

Differential Revision: D43712415

Summary:
Changelog: [Internal]

Turns out that Phabricator strips `@` symbol from `@...` tags when exports commits to GitHub. Proposing to use `#` instead.

#publish-packages-to-npm

Differential Revision: D43712415

fbshipit-source-id: 6e08e3a3d229e798e82e6db685974bf914dfbfe4
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43712415

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,476,862 +0
android hermes armeabi-v7a 7,799,361 +0
android hermes x86 8,953,156 +0
android hermes x86_64 8,810,873 +0
android jsc arm64-v8a 9,107,949 +0
android jsc armeabi-v7a 8,305,122 +0
android jsc x86 9,159,120 +0
android jsc x86_64 9,418,604 +0

Base commit: 4e117cb
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b72dc7f.

hoxyq added a commit to hoxyq/react-native that referenced this pull request Mar 2, 2023
Summary:
Pull Request resolved: facebook#36348

Changelog: [Internal]

Turns out that Phabricator strips `@` symbol from `@...` tags when exports commits to GitHub. Proposing to use `#` instead.

#publish-packages-to-npm

Reviewed By: cortinico

Differential Revision: D43712415

fbshipit-source-id: 86fc728eb0cb63afb6a9fe592a9ae998da2ce2e4
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36348

Changelog: [Internal]

Turns out that Phabricator strips `@` symbol from `@...` tags when exports commits to GitHub. Proposing to use `#` instead.

#publish-packages-to-npm

Reviewed By: cortinico

Differential Revision: D43712415

fbshipit-source-id: 86fc728eb0cb63afb6a9fe592a9ae998da2ce2e4
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants