Use SocketRocket for web socket library #36347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 4e117cb |
|
Would it be possible to provide a diff between RCTSRWebSocket.m and the version we'll be using now? We've had a number of local changes which we need to ensure aren't lost. |
Sure, I've got a diff here: This was formed by copying over SocketRocket's versions into their RCTSRWebSocket equivalents. The diffs are a bit gross since things don't perfectly line up, but if there are ways to coerce the diffs to look the way we want them, I'm happy to help with that. |
|
Can't see any massive differences, but as you say, it's a bit hard to compare. Will pull this to our internal CI, as that will require some work to update the dep. |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Mar 14, 2023
Summary: The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. ## Changelog [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 4be7de1fce2183133462c0243b4b3309b02043f5
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Mar 16, 2023
Summary: Pull Request resolved: facebook#36471 The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Reviewed By: cortinico Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 11e1ac2700bc92991897c594622e6687339bfcbf
4 tasks
microsoft-github-policy-service bot
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 18, 2023
Summary: Pull Request resolved: facebook#36471 The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Reviewed By: cortinico Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 11e1ac2700bc92991897c594622e6687339bfcbf Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Mar 21, 2023
Summary: Pull Request resolved: facebook#36471 The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Reviewed By: cortinico Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 11e1ac2700bc92991897c594622e6687339bfcbf
Merged
4 tasks
microsoft-github-policy-service bot
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 21, 2023
Summary: Pull Request resolved: facebook#36471 The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Reviewed By: cortinico Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 11e1ac2700bc92991897c594622e6687339bfcbf Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36471 The previous native web socket API, `RCTSRWebSocket`, appears to be an older version of the one provided as part of [SocketRocket](https://github.com/facebookincubator/SocketRocket). The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app. Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds. ## Changelog [IOS] [CHANGED] - Use SocketRocket for web socket library Pull Request resolved: facebook#36347 Test Plan: Validated the following: * The WebSocket test page in RNTester * Live reloading Reviewed By: cortinico Differential Revision: D43768835 Pulled By: javache fbshipit-source-id: 11e1ac2700bc92991897c594622e6687339bfcbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous native web socket API,
RCTSRWebSocket, appears to be an older version of the one provided as part of SocketRocket. The latter has several improvements, such as the ability to respect proxy settings, which has been requested by a user of a React Native app.Everything translates over pretty easily, and considering that SocketRocket is already a dependency of Flipper, there doesn't seem to be much additional cost to swapping out the libraries. If we wanted to make things even slimmer, it may even be possible to make the WebSocket library be optional for release builds.
Changelog
[IOS] [CHANGED] - Use SocketRocket for web socket library
Test Plan
Validated the following: