Enforce compatibility with exactOptionalPropertyTypes
#36345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43700862 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -281,12 +281,10 @@ export function SectionList_scrollable(Props: { | |||
| ref={ref} | |||
| ListHeaderComponent={HeaderComponent} | |||
| ListFooterComponent={FooterComponent} | |||
| // eslint-disable-next-line react/no-unstable-nested-components | |||
| // $FlowFixMe[missing-local-annot] | |||
| SectionSeparatorComponent={info => ( | |||
There was a problem hiding this comment.
⚠️ packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 285 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)
| // $FlowFixMe[missing-local-annot] | ||
| SectionSeparatorComponent={info => ( | ||
| <CustomSeparatorComponent {...info} text="SECTION SEPARATOR" /> | ||
| )} | ||
| // eslint-disable-next-line react/no-unstable-nested-components | ||
| // $FlowFixMe[missing-local-annot] | ||
| ItemSeparatorComponent={info => ( |
There was a problem hiding this comment.
⚠️ packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 289 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)
Base commit: f4e56fd |
|
This pull request was exported from Phabricator. Differential Revision: D43700862 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 1, 2023
Summary: Pull Request resolved: facebook#36345 `exactOptionalPropertyTypes` is a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicit `undefined`. This is not enabled when using `--strict`, and is stricter than Flow, leading to most of the typings having an `| undefined` unique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663). We have not always followed this (I have myself previously assumed the two are equivalent). We can enforce that the convention is followed with a plugin `eslint-plugin-redundant-undefined`. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint rule `no-redundant-undefined`. Changelog: [General][Fixed] - Enforce compatibility with `exactOptionalPropertyTypes` Differential Revision: D43700862 fbshipit-source-id: 2dd18244145bd95935effeb1476a2ab010f2a32e
NickGerleman
force-pushed
the
export-D43700862
branch
from
76c1aaa
to
7295a1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43700862 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 1, 2023
Summary: Pull Request resolved: facebook#36345 `exactOptionalPropertyTypes` is a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicit `undefined`. This is not enabled when using `--strict`, and is stricter than Flow, leading to most of the typings having an `| undefined` unique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663). We have not always followed this (I have myself previously assumed the two are equivalent). We can enforce that the convention is followed with a plugin `eslint-plugin-redundant-undefined`. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint rule `no-redundant-undefined`. Changelog: [General][Fixed] - Enforce compatibility with `exactOptionalPropertyTypes` Differential Revision: D43700862 fbshipit-source-id: 20dcbdf02dda4c2ab5c0d61b4d3bee16475b7b44
NickGerleman
force-pushed
the
export-D43700862
branch
from
7295a1a
to
33a16f9
Compare
eps1lon
reviewed
Mar 2, 2023
| @@ -18,6 +18,7 @@ | |||
| "strict-export-declare-modifiers": false, | |||
| "whitespace": false, | |||
| "use-default-type-parameter": false, | |||
| "no-redundant-jsdoc": false | |||
| "no-redundant-jsdoc": false, | |||
| "no-any-union": false | |||
There was a problem hiding this comment.
For what type do we need this currently?
There was a problem hiding this comment.
There are two in "globals.d.ts", where at least the websocket one is consistent with the ones TypeScript provides for browser code.
There was a problem hiding this comment.
We could constrain it a little more, but I think it would make a typing error for anything already assuming it is a specific value without checking.
|
I left a separate comment in microsoft/TypeScript#44419 (comment) since this style of mass-redundant-undefined removes signal the app is asking for, by saying explicit undefined is okay by default. We certainly haven't tested that it always works, but the main source of truth We could also instead clean the slate, and effectively undo DefinitelyTyped/DefinitelyTyped@694c663, so that future Also FYI @orta since you seem to have good context on how we should be treating these options 😅. |
NickGerleman
force-pushed
the
export-D43700862
branch
from
33a16f9
to
2c5fc91
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 8, 2023
Summary: Pull Request resolved: facebook#36345 `exactOptionalPropertyTypes` is a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicit `undefined`. This is not enabled when using `--strict`, and is stricter than Flow, leading to most of the typings having an `| undefined` unique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663). We have not always followed this (I have myself previously assumed the two are equivalent). We can enforce that the convention is followed with a plugin `eslint-plugin-redundant-undefined`. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint rule `no-redundant-undefined`. Changelog: [General][Fixed] - Enforce compatibility with `exactOptionalPropertyTypes` Reviewed By: lunaleaps Differential Revision: D43700862 fbshipit-source-id: df1b7c99909db3b761fd6dd7498c1cf6c1cfa6fd
|
This pull request was exported from Phabricator. Differential Revision: D43700862 |
Summary: Pull Request resolved: facebook#36345 `exactOptionalPropertyTypes` is a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicit `undefined`. This is not enabled when using `--strict`, and is stricter than Flow, leading to most of the typings having an `| undefined` unique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663). We have not always followed this (I have myself previously assumed the two are equivalent). We can enforce that the convention is followed with a plugin `eslint-plugin-redundant-undefined`. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint rule `no-redundant-undefined`. Changelog: [General][Fixed] - Enforce compatibility with `exactOptionalPropertyTypes` Reviewed By: lunaleaps Differential Revision: D43700862 fbshipit-source-id: 85dd15b77a0b65304453395034bc52b60694b47b
NickGerleman
force-pushed
the
export-D43700862
branch
from
2c5fc91
to
6d61a30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43700862 |
|
This pull request has been merged in 7858a21. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36345 `exactOptionalPropertyTypes` is a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicit `undefined`. This is not enabled when using `--strict`, and is stricter than Flow, leading to most of the typings having an `| undefined` unique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663). We have not always followed this (I have myself previously assumed the two are equivalent). We can enforce that the convention is followed with a plugin `eslint-plugin-redundant-undefined`. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint rule `no-redundant-undefined`. Changelog: [General][Fixed] - Enforce compatibility with `exactOptionalPropertyTypes` Reviewed By: lunaleaps Differential Revision: D43700862 fbshipit-source-id: 996094762b28918177521a9471d868ba87f0f263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
exactOptionalPropertyTypesis a TypeScript 4.4+ option set by users which changes behavior of optional properties, to disable accepting explicitundefined.This is not enabled when using
--strict, and is stricter than Flow, leading to most of the typings having an| undefinedunique to TypeScript (added with DefinitelyTyped/DefinitelyTyped@694c663).We have not always followed this (I have myself previously assumed the two are equivalent), so this sets the flag in our tsconfig, and updates properties which are not compatible right now.
We can enforce that the convention is followed with a plugin
eslint-plugin-redundant-undefined. This forces us to declare that every optional property accepts an explicit undefined (which Flow would allow). Alternatively, if we do not want to support this, we can enable the existing dtslint ruleno-redundant-undefined.Changelog:
[General][Fixed] - Enforce compatibility with
exactOptionalPropertyTypesDifferential Revision: D43700862