feat: Add logical border block color properties #35999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 83743e1 |
gabrieldonadel
commented
Jan 30, 2023
Comment on lines
+104
to
+106
| @property (nonatomic, assign) CGFloat borderBlockWidth; | ||
| @property (nonatomic, assign) CGFloat borderBlockEndWidth; | ||
| @property (nonatomic, assign) CGFloat borderBlockStartWidth; |
There was a problem hiding this comment.
I'll put up a follow-up PR implementing this but this is necessary here due to RCT_VIEW_BORDER_PROPERTY which creates set functions for both border##SIDE##Color and border##SIDE##Width
74 tasks
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR implements logical border block color properties as requested on facebook#34425. This implementation includes the addition of the following style properties - `borderBlockColor`, equivalent to `borderTopColor` and `borderBottomColor`. - `borderBlockEndColor`, equivalent to `borderBottomColor`. - `borderBlockStartColor`, equivalent to `borderTopColor`. ## Changelog [GENERAL] [ADDED] - Add logical border block color properties Pull Request resolved: facebook#35999 Test Plan: 1. Open the RNTester app and navigate to the `View` page 2. Test the new style properties through the `Logical Border Color` section <table> <tr> <td>Android</td> <td>iOS</td> </tr> <tr> <td><video src="https://user-images.githubusercontent.com/11707729/215384882-5b96518e-ad70-4157-a7f3-130f488cc41c.mov" alt="1" width="360px" /> </td> <td> <video src="https://user-images.githubusercontent.com/11707729/215392728-cfc6a097-26c1-4ffe-ab0e-f0a5a71a902d.mov"2" width="360px" /> </td> </tr> </table> Reviewed By: cipolleschi Differential Revision: D42849911 Pulled By: jacdebug fbshipit-source-id: 822cff5264689c42031d496105537032b5cd31ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements logical border block color properties as requested on #34425. This implementation includes the addition of the following style properties
borderBlockColor, equivalent toborderTopColorandborderBottomColor.borderBlockEndColor, equivalent toborderBottomColor.borderBlockStartColor, equivalent toborderTopColor.Changelog
[GENERAL] [ADDED] - Add logical border block color properties
Test Plan
ViewpageLogical Border ColorsectionScreen.Recording.2023-01-30.at.01.01.44.mov
Screen.Recording.2023-01-30.at.02.12.26.mov