feat(react-native/template): use verdaccio to publish local packages before testing template app #35444

hoxyq · 2022-11-23T17:36:16Z

Summary:
Changelog:
[Internal][Changed] - now using Verdaccio to publish necessary packages for template app

Adds script /scripts/template/install-dependencies.js, which incapsulates the logic of installing dependencies of template app
The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm
This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules

Differential Revision: D41498086

facebook-github-bot · 2022-11-23T17:36:59Z

This pull request was exported from Phabricator. Differential Revision: D41498086

facebook-github-bot · 2022-11-23T17:44:32Z

This pull request was exported from Phabricator. Differential Revision: D41498086

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to [package-ifying Animated, VirtualizedList, FlatList modules](facebook#35263) Differential Revision: D41498086 fbshipit-source-id: adf19f547e552ff2f438a645f03f225921514d5e

facebook-github-bot · 2022-11-23T17:53:47Z

This pull request was exported from Phabricator. Differential Revision: D41498086

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Differential Revision: D41498086 fbshipit-source-id: 5503830d52517811c12467f25d702ab563d7f374

analysis-bot · 2022-11-23T18:14:01Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: c5a8425
Branch: main

analysis-bot · 2022-11-23T18:16:39Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,569	+0
android	hermes	armeabi-v7a	6,470,637	+0
android	hermes	x86	7,520,037	+0
android	hermes	x86_64	7,378,724	+0
android	jsc	arm64-v8a	8,967,444	+0
android	jsc	armeabi-v7a	7,698,293	+0
android	jsc	x86	9,029,584	+0
android	jsc	x86_64	9,507,429	+0

Base commit: c5a8425
Branch: main

pull-bot · 2022-11-23T18:23:57Z

PR build artifact for 0ec2cf0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-23T18:28:59Z

PR build artifact for 0ec2cf0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinico · 2022-11-23T18:26:57Z

scripts/template/README.md

+execSync('npm publish --registry http://localhost:4873 --access public', {
+   cwd: `${reactNativeRootPath}/packages/<path-to-package>`,


Can we instead have a top level array and ask users just to add the package path to the array? We can then iterate over the array and npm publish?

Yes, that will be even easier for the user

facebook-github-bot · 2022-11-23T18:48:42Z

This pull request was exported from Phabricator. Differential Revision: D41498086

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Reviewed By: cortinico Differential Revision: D41498086 fbshipit-source-id: cd8656d638a22ab5aa79ee46850e0c9819839e3f

pull-bot · 2022-11-23T19:19:57Z

PR build artifact for 930bcfe is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-23T19:25:31Z

PR build artifact for 930bcfe is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Reviewed By: cortinico Differential Revision: D41498086 fbshipit-source-id: 6533c5272616c331b00a331d11e8cde02b617713

facebook-github-bot · 2022-11-23T19:52:01Z

This pull request was exported from Phabricator. Differential Revision: D41498086

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Differential Revision: https://internalfb.com/D41498086 fbshipit-source-id: 6d5a3d4bb155ca22fcf41190992cc6679971d5d2

pull-bot · 2022-11-23T20:24:41Z

PR build artifact for 343836b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-23T20:28:55Z

PR build artifact for 343836b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

react-native-bot · 2022-11-23T21:25:09Z

This pull request was successfully merged by @hoxyq in e11cfe9.

^{When will my fix make it into a release? | Upcoming Releases}

…before testing template app (#35444) Summary: Pull Request resolved: #35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Reviewed By: cortinico Differential Revision: D41498086 fbshipit-source-id: 48fbbb1c9334e7a9e7657e6275b7b04f9ce290b5

…before testing template app (facebook#35444) Summary: Pull Request resolved: facebook#35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Reviewed By: cortinico Differential Revision: D41498086 fbshipit-source-id: 48fbbb1c9334e7a9e7657e6275b7b04f9ce290b5

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 23, 2022

hoxyq force-pushed the export-D41498086 branch from 08141a7 to 9b0331e Compare November 23, 2022 17:44

hoxyq force-pushed the export-D41498086 branch from 9b0331e to 0ec2cf0 Compare November 23, 2022 17:53

cortinico approved these changes Nov 23, 2022

View reviewed changes

hoxyq force-pushed the export-D41498086 branch from 0ec2cf0 to 930bcfe Compare November 23, 2022 18:48

hoxyq force-pushed the export-D41498086 branch from 930bcfe to 343836b Compare November 23, 2022 19:52

facebook-github-bot closed this in e11cfe9 Nov 23, 2022

react-native-bot added the Merged This PR has been merged. label Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(react-native/template): use verdaccio to publish local packages before testing template app #35444

feat(react-native/template): use verdaccio to publish local packages before testing template app #35444

hoxyq commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

analysis-bot commented Nov 23, 2022

analysis-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

cortinico Nov 23, 2022

hoxyq Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

react-native-bot commented Nov 23, 2022

		+execSync('npm publish --registry http://localhost:4873 --access public', {
		+ cwd: `${reactNativeRootPath}/packages/<path-to-package>`,

feat(react-native/template): use verdaccio to publish local packages before testing template app #35444

feat(react-native/template): use verdaccio to publish local packages before testing template app #35444

Conversation

hoxyq commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

analysis-bot commented Nov 23, 2022

analysis-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

cortinico Nov 23, 2022

Choose a reason for hiding this comment

hoxyq Nov 23, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

pull-bot commented Nov 23, 2022

react-native-bot commented Nov 23, 2022