Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual list type #35434

Closed
wants to merge 2 commits into from
Closed

Fix virtual list type #35434

wants to merge 2 commits into from

Conversation

aliakbarazizi
Copy link
Contributor

Summary

Add missing props to virtual list

Changelog

[General] [Fixed] - Virtual list props

Test Plan

relative pull request in DefinitelyTyped
DefinitelyTyped/DefinitelyTyped#63323

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2022
@analysis-bot
Copy link

analysis-bot commented Nov 22, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,588 +30
android hermes armeabi-v7a 6,470,669 +36
android hermes x86 7,520,065 +31
android hermes x86_64 7,378,750 +28
android jsc arm64-v8a 8,967,454 +11
android jsc armeabi-v7a 7,698,320 +30
android jsc x86 9,029,603 +21
android jsc x86_64 9,507,453 +24

Base commit: 3eb69f2
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 22, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3eb69f2
Branch: main

@pull-bot
Copy link

PR build artifact for 389f570 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 389f570 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Remove extra props
@pull-bot
Copy link

PR build artifact for e534fc1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for e534fc1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @aliakbarazizi in 6c33fd1.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2022
cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
Summary:
Add missing props to virtual list

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - Virtual list props

Pull Request resolved: #35434

Test Plan:
relative pull request in DefinitelyTyped
DefinitelyTyped/DefinitelyTyped#63323

Reviewed By: javache

Differential Revision: D41553396

Pulled By: NickGerleman

fbshipit-source-id: d51a93410ece9ad5f0bb61e2ee51076973e80c8c
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Add missing props to virtual list

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - Virtual list props

Pull Request resolved: facebook#35434

Test Plan:
relative pull request in DefinitelyTyped
DefinitelyTyped/DefinitelyTyped#63323

Reviewed By: javache

Differential Revision: D41553396

Pulled By: NickGerleman

fbshipit-source-id: d51a93410ece9ad5f0bb61e2ee51076973e80c8c
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants