Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] circleci node image updated #35404

Closed
wants to merge 2 commits into from
Closed

[core] circleci node image updated #35404

wants to merge 2 commits into from

Conversation

piwysocki
Copy link

@piwysocki piwysocki commented Nov 18, 2022

Summary

cimg/node images bumped to latest minor version

Changelog

[Internal] [Fixed] - Circleci node image updated

Test Plan

@analysis-bot
Copy link

analysis-bot commented Nov 18, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,588 +0
android hermes armeabi-v7a 6,470,669 +0
android hermes x86 7,520,065 +0
android hermes x86_64 7,378,750 +0
android jsc arm64-v8a 8,967,454 +0
android jsc armeabi-v7a 7,698,320 +0
android jsc x86 9,029,603 +0
android jsc x86_64 9,507,453 +0

Base commit: 0d3d002
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 18, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0d3d002
Branch: main

@pull-bot
Copy link

PR build artifact for adec3cf is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

Hi @piwysocki!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@pull-bot
Copy link

PR build artifact for d36248e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2022
@cortinico
Copy link
Contributor

We most likely won't be doing this as we're looking into bumping Node version (see here #35443)

@piwysocki piwysocki closed this by deleting the head repository Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants