-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Text props aria-labelledby documentation #35327
chore: Update Text props aria-labelledby documentation #35327
Conversation
Base commit: f453292 |
We'll keep it because it's for cross platform purpose, other platforms need it, and maybe Text for native can have it too one day |
Base commit: a7ae988 |
PR build artifact for 632568c is ready. |
Got it, but wouldn't it be good if we have some comment explaining this? Just to prevent people like me from trying to remove it as there's no link between |
Yeah good idea |
632568c
to
e9dd5c0
Compare
@necolas updated |
PR build artifact for e30968e is ready. |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: `aria-labelledby` Flow types were added to the Text props on facebook@f353119 but the text component does not support `accessibilityLabelledBy`, which is the prop we were supposed to map `aria-labelledby` to. As the Text component does not really support `aria-labelledby` this PR updates the `TextProps` documentation to explain that this prop is necessary for cross-platform purposes and that other platforms need it. ## Changelog [Android] [Changed] - Add notes to `aria-labelledby` from Text props Pull Request resolved: facebook#35327 Test Plan: Ensure CI is green Reviewed By: necolas Differential Revision: D41280877 Pulled By: lunaleaps fbshipit-source-id: 81cf016bcf3117f15385ddd119c44d6f9fdd6b68
Summary
aria-labelledby
Flow types were added to the Text props on f353119 but the text component does not supportaccessibilityLabelledBy
, which is the prop we were supposed to maparia-labelledby
to. As the Text component does not really supportaria-labelledby
this PR updates theTextProps
documentation to explain that this prop is necessary for cross-platform purposes and that other platforms need it.Changelog
[Android] [Changed] - Add notes to
aria-labelledby
from Text propsTest Plan
Ensure CI is green