-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update TextInput inputMode to map "none" to showSoftInputOnFocus #35228
feat: Update TextInput inputMode to map "none" to showSoftInputOnFocus #35228
Conversation
I wonder if this should be a little more complicated in case it's bizarre to have an inputMode set and the showSoftInputOnFocus set. Should the latter be ignored entirely if inputMode is defined? |
Base commit: 7a327d9 |
Base commit: 7a327d9 |
PR build artifact for 0b660f4 is ready. |
@necolas we could do |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I was thinking more like |
Got it, I've just updated it to use this logic |
Thanks. We'll reimport and double check |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
PR build artifact for dc20e4e is ready. |
This pull request was successfully merged by @gabrieldonadel in b6869be. When will my fix make it into a release? | Upcoming Releases |
facebook#35228) Summary: This PR updates `inputMode` prop from the `TextInput` component to map the `none` option to `showSoftInputOnFocus={false}` as suggested by necolas here -> facebook#34460 (comment). This change makes the inputMode API behaves a bit more similarly across platforms. Related to necolas/react-native-web#2421 ## Changelog [General] [Changed] - Update TextInput inputMode to map "none" to showSoftInputOnFocus ## Test Plan 1. Open the RNTester app and navigate to the TextInput page 2. Test the `TextInput` component through the `Input modes` section https://user-images.githubusercontent.com/11707729/200218435-6a33b319-e989-4086-aac3-506546982b38.mov Pull Request resolved: facebook#35228 Reviewed By: lunaleaps, necolas Differential Revision: D41081876 Pulled By: jacdebug fbshipit-source-id: cc634c3723647d8950bf2cfe67be70d0fbd488a6
Summary
This PR updates
inputMode
prop from theTextInput
component to map thenone
option toshowSoftInputOnFocus={false}
as suggested by @necolas here -> #34460 (comment). This change makes the inputMode API behaves a bit more similarly across platforms.Related to necolas/react-native-web#2421
Changelog
[General] [Changed] - Update TextInput inputMode to map "none" to showSoftInputOnFocus
Test Plan
TextInput
component through theInput modes
sectionScreen.Recording.2022-11-07.at.00.08.58.mov