Link against the app codegen if available #35176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit extends the ReactNative-application.cmake logic so that if the app is using codegen at the app level, the generate library is properly built and linked. It helps us simplify the RN Tester setup and makes it easier for app users to use the codegen at the app level. Changelog: [Internal] [Changed] - [Android] Link against the app codegen if available Differential Revision: D40936941 fbshipit-source-id: 4ef9403ccc49a655dfbc8c60c72838bd857a0c3a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40936941 |
Base commit: 74cb441 |
Base commit: 64c3906 |
|
PR build artifact for 1acac17 is ready. |
|
PR build artifact for 1acac17 is ready. |
|
This pull request was successfully merged by @cortinico in 0fd282f. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35176 This commit extends the ReactNative-application.cmake logic so that if the app is using codegen at the app level, the generate library is properly built and linked. It helps us simplify the RN Tester setup and makes it easier for app users to use the codegen at the app level. Changelog: [Internal] [Changed] - [Android] Link against the app codegen if available Reviewed By: cipolleschi Differential Revision: D40936941 fbshipit-source-id: 26fa4d764fb369c987e94e0c3bce61841b982b27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit extends the ReactNative-application.cmake logic so
that if the app is using codegen at the app level, the generate library
is properly built and linked.
It helps us simplify the RN Tester setup and makes it easier for app users
to use the codegen at the app level.
Changelog:
[Internal] [Changed] - [Android] Link against the app codegen if available
Differential Revision: D40936941