-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected documentation to be more gramatically correct #35141
Corrected documentation to be more gramatically correct #35141
Conversation
Base commit: 87c356d |
Base commit: 87c356d |
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase |
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @willsawyerrrr in 74cb441. When will my fix make it into a release? | Upcoming Releases |
Hey @cipolleschi @rshest ! I would suggest following things in order to stop the wastage of compute resources for NON CODE/DOC changes:
PS: Sorry for tagging all of you, just wanted to make sure this is not ignored |
Summary: The documentation for `useColorScheme()` suggested that the user's preferred color scheme will be 'Dark Mode'. Instead suggesting 'Dark Mode' as an example of what the user's preferred color scheme could be is more correct. ## Changelog [INTERNAL] [FIXED] - Edited documentation for `useColorScheme()` hook Edited ```javascript /** * A new useColorScheme hook is provided as the preferred way of accessing * the user's preferred color scheme (aka Dark Mode). */ export function useColorScheme(): ColorSchemeName; ``` to ```javascript /** * A new useColorScheme hook is provided as the preferred way of accessing * the user's preferred color scheme (e.g. Dark Mode). */ export function useColorScheme(): ColorSchemeName; ``` Pull Request resolved: facebook#35141 Test Plan: Documentation only - no testing required. Reviewed By: cipolleschi Differential Revision: D40934781 Pulled By: rshest fbshipit-source-id: acac8947c3f99016839be27f505066e8992a20fa
Summary
The documentation for
useColorScheme()
suggested that the user's preferred color scheme will be 'Dark Mode'. Instead suggesting 'Dark Mode' as an example of what the user's preferred color scheme could be is more correct.Changelog
[INTERNAL] [FIXED] - Edited documentation for
useColorScheme()
hookEdited
to
Test Plan
Documentation only - no testing required.