[Codegen] Improve assertGenericTypeAnnotationHasExactlyOneTypeParameter tests #34942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
| const flowTypeAnnotation = { | ||
| typeParameters: { | ||
| type: 'TypeParameterInstantiation', | ||
| type: 'wrongType', |
Author
There was a problem hiding this comment.
This test case was ok because an Error was thrown even though the type had the correct value.
It was the fact that params was missing that caused an Error to be thrown.
cipolleschi
requested changes
Oct 11, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Hi @AntoineDoubovetzky, thanks a lot for this extra PR that shows how much you care. 🥰
Can you fix the linting error? It looks like there is an unused variable in the code!
Base commit: f353119 |
Base commit: f353119 |
Author
|
@cipolleschi Sorry I didn't notice the unused import. I removed it! |
cipolleschi
approved these changes
Oct 14, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Sorry, I missed this! It looks good!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Oct 18, 2022
Collaborator
|
This pull request was successfully merged by @AntoineDoubovetzky in 790f40c. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#34942) Summary: facebook#34933 has been merged just after I pushed a new commit to the branch to improve tests of `assertGenericTypeAnnotationHasExactlyOneTypeParameter` function, but the last commit was not imported to the internal repository. The `assertGenericTypeAnnotationHasExactlyOneTypeParameter` can throw different types of Error, and I believe that `.toThrow(Error)` is not specific enough. So I replaced it with `toThrowErrorMatchingInlineSnapshot()`. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Improve assertGenericTypeAnnotationHasExactlyOneTypeParameter tests in parsers-commons Pull Request resolved: facebook#34942 Test Plan: Some test cases were ok because the assertGenericTypeAnnotationHasExactlyOneTypeParameter function threw an Error, but for the wrong reason. I've made sure that the error displayed in the inline snapshot is the one we expect. Reviewed By: cortinico Differential Revision: D40384993 Pulled By: cipolleschi fbshipit-source-id: aaa943be1e808af2c5131f7d06baf24bc3bffa31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#34933 has been merged just after I pushed a new commit to the branch to improve tests of
assertGenericTypeAnnotationHasExactlyOneTypeParameterfunction, but the last commit was not imported to the internal repository.The
assertGenericTypeAnnotationHasExactlyOneTypeParametercan throw different types of Error, and I believe that.toThrow(Error)is not specific enough. So I replaced it withtoThrowErrorMatchingInlineSnapshot().Changelog
[Internal] [Changed] - Improve assertGenericTypeAnnotationHasExactlyOneTypeParameter tests in parsers-commons
Test Plan
Some test cases were ok because the assertGenericTypeAnnotationHasExactlyOneTypeParameter function threw an Error, but for the wrong reason. I've made sure that the error displayed in the inline snapshot is the one we expect.