-
Notifications
You must be signed in to change notification settings - Fork 25k
[Codegen]: Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function #34908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Base commit: db8c11d |
Base commit: db8c11d |
rshest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for this change!!! Would it be possible to rename parser-primitives-test.js into parsers-primitives-test.js, so that's it is consistent with the corresponding name of the file under test (parsers-primitives.js)? Thanks!
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @youedd in 54fc62c. When will my fix make it into a release? | Upcoming Releases |
…tNumber function (facebook#34908) Summary: Part of facebook#34872 This PR: - extracts the content of the case 'NumberTypeAnnotation' ([Flow](https://github.com/facebook/react-native/blob/b444f0e44e0d8670139acea5f14c2de32c5e2ddc/packages/react-native-codegen/src/parsers/flow/modules/index.js#L370-L372), [TypeScript](https://github.com/facebook/react-native/blob/00b795642a6562fb52d6df12e367b84674994623/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L405-L407)) into a single emitNumber function in the parsers-primitives.js file, and uses the new function in the parsers - unit tests emitNumber function ## Changelog [Internal] [Changed] - Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function Pull Request resolved: facebook#34908 Test Plan: ` yarn jest react-native-codegen` <img width="935" alt="image" src="https://user-images.githubusercontent.com/19575877/194764122-44975a97-3acd-4f27-babe-ddcd58c3ec61.png"> Reviewed By: cipolleschi Differential Revision: D40214542 Pulled By: cipolleschi fbshipit-source-id: a7746d3f1dd5f127dc520c6156383b18e00281ec
Summary
Part of #34872
This PR:
Changelog
[Internal] [Changed] - Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function
Test Plan
yarn jest react-native-codegen