New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues for nightly build #34846

Closed

Kudo wants to merge 2 commits into facebook:main from Kudo:fix-nightly

Contributor

Kudo commented Oct 3, 2022

Summary

There are two issues from nightly builds.

1. `VERSION_NAME=1000.0.0-main` in ReactAndroid/gradle.properties

the solution is to remove unused ReactAndroid/gradle.properties git revert when publishing package.

2. `pod install` error from downloading hermes, e.g. the url is unavailable. `https://github.com/facebook/react-native/releases/download/v0.0.0-20221002-2027-2319f75c8/hermes-runtime-darwin-debug-v0.0.0-20221002-2027-2319f75c8.tar.gz`

fix hermes-engine.podspec to support nightly build and build hermes from main branch.

Changelog

[General] [Fixed] - Fix nightly build issues

Test Plan

i cannot fully test publish-npm.js workflow and it stops at npm publish. i can just check at this moment, the ReactAndroid/gradle.properties is right.
create a npx react-native init project and yarn add react-native@nightly. patch node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec and try pod install


          Fix issues for nightly build

9c3463a

facebook-github-bot added CLA Signed Contributor p: Expo Partner Shared with Meta labels


          remove unused import

6e5e669

Kudo mentioned this pull request

Add setup-nightly script for 3rd party libs to test nightly builds #34838

Closed

analysis-bot commented Oct 3, 2022

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,739,161	+0
android	hermes	armeabi-v7a	7,141,579	+0
android	hermes	x86	8,050,059	+0
android	hermes	x86_64	8,021,773	+0
android	jsc	arm64-v8a	9,607,326	+0
android	jsc	armeabi-v7a	8,372,583	+0
android	jsc	x86	9,554,794	+0
android	jsc	x86_64	10,147,276	+0

Base commit: 9d08d55
Branch: main

cortinico approved these changes

View reviewed changes

sdks/hermes-engine/hermes-engine.podspec

@@ @@ -28,7 +28,7 @@ git = "https://github.com/facebook/hermes.git" @@
               if ENV.has_key?('HERMES_ENGINE_TARBALL_PATH')
                 Pod::UI.puts '[Hermes] Using pre-built Hermes binaries from local path.' if Object.const_defined?("Pod::UI")
                 source[:http] = "file://#{ENV['HERMES_ENGINE_TARBALL_PATH']}"
-              elsif version == '1000.0.0'
+              elsif version == '1000.0.0' || version.start_with?('0.0.0-')

Contributor

cortinico Oct 3, 2022

This is going to change soon as we're looking for a place where to store hermes tarballs also for nightlies: react-native-community/discussions-and-proposals#508

Contributor Author

Kudo Oct 3, 2022

that's super helpful where we could test nightly without building hermes from source 🎉

Contributor

cortinico commented Oct 3, 2022

cc @kelset as you've been working on this recently

Contributor

facebook-github-bot commented Oct 3, 2022

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor

kelset commented Oct 3, 2022 •

edited

Loading

hey @Kudo - for context, I've done changes in this area of the code in two places:

lmk if there's anything I need to modify over there to ensure everything works correctly

Contributor Author

Kudo commented Oct 3, 2022

hey @Kudo - for context, I've done changes in this area of the code in two places:

infra(e2e): rework local E2E script #34513

chore: re-align version to be 1000.0.0 on main everywhere #34817

lmk if there's anything I need to modify over there to ensure everything works correctly

thanks for these information @kelset. the pr is not in hurry at all, as at expo we have some postinstall workaround to fix these issues. i can wait your prs to be landed first and see if there're any necessary changes then.

Kudo mentioned this pull request

[core][dev-client] Support react-native nightly builds expo/expo#19369

Merged

3 tasks

facebook-github-bot closed this in

93c3eff

Contributor Author

Kudo commented Oct 3, 2022

oh no this pr landed first, sorry @kelset 😅 let me know if there's anything i can help for your prs .

Contributor

kelset commented Oct 3, 2022

ahah no worries, I'll probably have a new small merge conflict to handle but everything should be fine 👍

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

1 similar comment

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

Contributor Author

Kudo commented Oct 3, 2022

thanks @kelset and everyone helps with pr reviews as always.

Kudo deleted the fix-nightly branch

October 3, 2022 15:31

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

5 similar comments

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

Collaborator

react-native-bot commented Oct 3, 2022

This pull request was successfully merged by @Kudo in 93c3eff.

^{When will my fix make it into a release? | Upcoming Releases}

facebook locked as resolved and limited conversation to collaborators

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request


          Fix issues for nightly build (facebook#34846)

c57c422

Summary:
There are two issues from nightly builds.

#### 1. `VERSION_NAME=1000.0.0-main` in  _ReactAndroid/gradle.properties_

the solution is to remove unused _ReactAndroid/gradle.properties_  git revert when publishing package.

#### 2. `pod install` error from downloading hermes, e.g. the url is unavailable. `https://github.com/facebook/react-native/releases/download/v0.0.0-20221002-2027-2319f75c8/hermes-runtime-darwin-debug-v0.0.0-20221002-2027-2319f75c8.tar.gz`

fix _hermes-engine.podspec_ to support nightly build and build hermes from main branch.

## Changelog

[General] [Fixed] - Fix nightly build issues

Pull Request resolved: facebook#34846

Test Plan:
1. i cannot fully test publish-npm.js workflow and it stops at `npm publish`. i can just check at this moment, the _ReactAndroid/gradle.properties_ is right.
2. create a `npx react-native init` project and `yarn add react-native@nightly`. patch `node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec` and try `pod install`

Reviewed By: cipolleschi

Differential Revision: D40021649

Pulled By: cortinico

fbshipit-source-id: c9e2701e524f4b16eab6f2c72b5cfa34883082c3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed Contributor p: Expo Partner Shared with Meta