Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NMake generator for Hermes build on Windows #34790

Closed
wants to merge 1 commit into from
Closed

Use NMake generator for Hermes build on Windows #34790

wants to merge 1 commit into from

Conversation

mganandraj
Copy link
Contributor

@mganandraj mganandraj commented Sep 26, 2022 •
edited
Loading

CMake on Windows uses "Visual Studio **" generators are multi-configuration,

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available.

Summary

Use NMake generator for Hermes build on Windows

Changelog

CMake on Windows uses "Visual Studio **" generators are multi-configuration,

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available.

[Android] [Fixed] - Use NMake generator for Hermes build on Windows

Test Plan

Verified that RN build on Windows with multiple SKUs of Visual studio.d

@mganandraj
CMake on Windows uses "Visual Studio **" generator when available. "V…
c859347 
…isual Studio **" generators are multi-configuraiton (https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible.
Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler.
Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" is available.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 26, 2022
@mganandraj mganandraj mentioned this pull request Sep 26, 2022
Closed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,727,567 +0
android hermes armeabi-v7a 7,130,453 +0
android hermes x86 8,034,128 +0
android hermes x86_64 8,007,407 +0
android jsc arm64-v8a 9,596,918 +0
android jsc armeabi-v7a 8,363,229 +0
android jsc x86 9,541,151 +0
android jsc x86_64 10,133,547 +0

Base commit: 8cdc9e7
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5fb0639
Branch: main

@mganandraj mganandraj changed the title CMake on Windows uses "Visual Studio **" generator when available. "V… Use NMake generator for Hermes build on Windows Sep 27, 2022
@cortinico
Copy link
Contributor

Thanks for sendign this @mganandraj
Can you fill in the Changelog format as suggested by Danger?

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Sep 27, 2022
@mganandraj
Copy link
Contributor Author

Done .. The other errors seem unrelated to this change.

@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

8 similar comments
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 9d08d55.

When will my fix make it into a release? | Upcoming Releases

kelset pushed a commit that referenced this pull request Oct 11, 2022
@mganandraj @kelset
Use NMake generator for Hermes build on Windows (#34790)
ebf746b 
Summary:
CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available.

Use NMake generator for Hermes build on Windows

## Changelog
CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition"  with default packages  is available.

[Android] [Fixed] - Use NMake generator for Hermes build on Windows

Pull Request resolved: #34790

Test Plan: Verified that RN build on Windows with multiple SKUs of Visual studio.d

Reviewed By: cortinico

Differential Revision: D39889332

Pulled By: cortinico

fbshipit-source-id: f2d39d981e7c58c8cb93a4322155c844cb6bded3
@NOUIY NOUIY mentioned this pull request Nov 3, 2022
Open
@NOUIY NOUIY mentioned this pull request Nov 16, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 7, 2022
Open
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@mganandraj @OlimpiaZurek
Use NMake generator for Hermes build on Windows (facebook#34790)
3c14a33 
Summary:
CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available.

Use NMake generator for Hermes build on Windows

## Changelog
CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition"  with default packages  is available.

[Android] [Fixed] - Use NMake generator for Hermes build on Windows

Pull Request resolved: facebook#34790

Test Plan: Verified that RN build on Windows with multiple SKUs of Visual studio.d

Reviewed By: cortinico

Differential Revision: D39889332

Pulled By: cortinico

fbshipit-source-id: f2d39d981e7c58c8cb93a4322155c844cb6bded3
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Closed
@cipolleschi cipolleschi mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mganandraj @analysis-bot @cortinico @facebook-github-bot @react-native-bot